Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technologies section #85

Merged
merged 13 commits into from
Sep 4, 2023
Merged

Technologies section #85

merged 13 commits into from
Sep 4, 2023

Conversation

WarningImHack3r
Copy link
Member

@WarningImHack3r WarningImHack3r commented Aug 14, 2023

Implement the Technologies section according to the Figma file.

Features

  • Elegantly describes the 3 main technologies we (are planning to) use: Svelte(Kit), PostgreSQL & Vercel
  • Auto-scrolling tiles detailing the 3 technologies
  • Right part with circled images shaped in a triangle, each one with a stunning hover effect
  • Paused on hover on a text block

TODO

  • Fix the layout to get the same height for both parts while being uneven columns
  • Make responsive
  • Add programmatic hover effect trigger for images (a workaround because it's not technically possible), following which tile of the left part is currently displayed

@WarningImHack3r WarningImHack3r marked this pull request as ready for review August 25, 2023 13:25
@MinixBF
Copy link
Contributor

MinixBF commented Aug 29, 2023

@WarningImHack3r Check the responsive mode, it's broken

After testing it, I don't think the scroll bar looks too good on a PC.
What do you think of the fact that you can click on the technology to change?
I think it's a shame that the counter isn't reset to zero when you arrive at an element. Or even if you scroll down to see one. The scrolling goes backwards, do you think we could fix that?

@WarningImHack3r
Copy link
Member Author

Check the responsive mode, it's broken

Indeed! Did not try with a width this small :O

After testing it, I don't think the scroll bar looks too good on a PC.

Didn't try it on Windows, I'll find a way to do it

What do you think of the fact that you can click on the technology to change?

Yes, I love this!!! Easy to do, I will do it

I think it's a shame that the counter isn't reset to zero when you arrive at an element. Or even if you scroll down to see one.

I don't really get what you mean...

The scrolling goes backwards, do you think we could fix that?

It's a deliberate choice, an "infinite carousel" illusion is tricky to make and it looked good enough like this. But if you want I can do it, what do you prefer?

@WarningImHack3r WarningImHack3r marked this pull request as draft August 30, 2023 22:10
@MinixBF
Copy link
Contributor

MinixBF commented Aug 30, 2023

It's a deliberate choice, an "infinite carousel" illusion is tricky to make and it looked good enough like this. But if you want I can do it, what do you prefer?

I want the "infinite carousel" but when I'm reading for example. If I scroll to view the PostgreSQL section I don't want to go back to Svelte automatically but to the next one. And after this one back to the first one

@WarningImHack3r WarningImHack3r mentioned this pull request Sep 1, 2023
3 tasks
- Fix responsive
- Add ability to click on icons to scroll to the right card
- Pause scroll also on hovering icons & scroll
- Change icon after scrolling on cards
@WarningImHack3r
Copy link
Member Author

Everything is fixed and improved (c.f. last commit details message), just tell me if you want an infinite scroll effect; otherwise, we should be good to go!

@WarningImHack3r WarningImHack3r marked this pull request as ready for review September 1, 2023 17:44
Copy link
Contributor

@MinixBF MinixBF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some bugs.
When i hover on technologies, it creates more scroll effect

@MinixBF
Copy link
Contributor

MinixBF commented Sep 1, 2023

test_tech.mp4

Copy link
Contributor

@MinixBF MinixBF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Easier to understand code.
We can add the glass background located in #97 before merging.

@MinixBF MinixBF self-requested a review September 3, 2023 08:19
@WarningImHack3r WarningImHack3r merged commit 2539cb2 into main Sep 4, 2023
5 checks passed
@WarningImHack3r WarningImHack3r deleted the techno-section branch September 4, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants