Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About us section #97

Merged
merged 18 commits into from
Sep 4, 2023
Merged

About us section #97

merged 18 commits into from
Sep 4, 2023

Conversation

MinixBF
Copy link
Contributor

@MinixBF MinixBF commented Aug 28, 2023

Add a new section to find out more about us

  • About us section
  • Change background to make a glass-morphism background
  • Add navbar link
    This is the first version of this section, which is why the text is centered. The aim will be to add a photo of us in the future.

@MinixBF MinixBF changed the title About us About us Section Aug 28, 2023
@MinixBF MinixBF changed the title About us Section About us section Aug 28, 2023
@MinixBF MinixBF marked this pull request as ready for review August 29, 2023 21:05
@MinixBF MinixBF marked this pull request as draft August 29, 2023 21:27
@MinixBF MinixBF marked this pull request as ready for review August 29, 2023 21:56
Copy link
Member

@WarningImHack3r WarningImHack3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and simple, nice!
There are a few typos in the text, we will need to rework it together once the rest is fixed.

Little wish, can't you try making a glass-morphism background instead of a basic gray one? Add at least a shadow to it ;)

src/lib/layouts/Section.svelte Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
Copy link
Member

@WarningImHack3r WarningImHack3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but waiting for glass-morphism 👀

@WarningImHack3r
Copy link
Member

WarningImHack3r commented Sep 1, 2023

Another thing: let's not forget the navbar links!
Currently, only the Process one is working. The Technologies one is also present for a while (#8), allowing #85 to work out of the box.
So please add a link to this section for Company.

Concerning the Solutions section I forgot to link to the navbar in #15 and the footer, we will likely do a separate PR once all the sections are done, that way everything will be linked!

Side note: We also will have to "hide" all the See more-like buttons from the page while the pages they are supposed to link to are not present yet. Maybe you can comment that part out, maybe it will be done in the "Cleanup" PR with the navbar & footer links I mentioned, maybe we will do it in a separate PR, I don't know what's the best option for now.

@MinixBF MinixBF mentioned this pull request Sep 3, 2023
3 tasks
Copy link
Member

@WarningImHack3r WarningImHack3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change

src/routes/+page.svelte Outdated Show resolved Hide resolved
src/routes/+page.svelte Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
Copy link
Member

@WarningImHack3r WarningImHack3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous Change request

Copy link
Member

@WarningImHack3r WarningImHack3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@MinixBF MinixBF merged commit a5b9dd4 into main Sep 4, 2023
5 checks passed
@MinixBF MinixBF deleted the about-us branch September 4, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants