Deep sleep and example #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacua
commented
Apr 26, 2024
| sLoRa_OTAA OTAA_Data; | ||
|
|
||
| // Declare LoRA settings struct | ||
| sSettings LoRa_Settings; | ||
| sRFM_pins LoRa_Pins; |
There was a problem hiding this comment.
Line 126 was remove since this vairable was not used at all at any place in the code.
sabas1080
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the code more friendly so ESP device can go to deep sleep without have to rejoined if OTAA is used. For doing so, private variable were move to public.