Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scene param types to their respective fiat plugin scene files #5287

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Move scene param types to their respective fiat plugin scene files #5287

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1352ed
Fix scroll issues on info display scene for sepa plugins
samholmes Oct 2, 2024
41c2b98
Move scene param types to their respective fiat plugin scene files
samholmes Oct 2, 2024
64f1b65
Use UI4 components for InfoDisplayScene
samholmes Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- fixed: Fixed obscured "done" button display bug on Sepa info display scene for small-screen devices

## 4.15.0

- added: Add Maya Protocol
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/gui/scenes/InfoDisplayScene.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const InfoDisplayScene = React.memo((props: Props) => {
))

return (
<SceneWrapper scroll hasNotifications>
<SceneWrapper hasTabs scroll hasNotifications>
Copy link
Collaborator

@Jon-edge Jon-edge Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, fix the InfoDisplayScene using deprecated components like MainButton to use SceneButtons. This should be a primary button (which SceneButtons and all button group components enforce automatically)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have screenshots in visual PRs so reviewers can catch these mistakes easier.

<SceneHeader title={headerTitle} underline withTopMargin />
<View style={styles.promptContainer}>
<EdgeText numberOfLines={12}>{promptMessage}</EdgeText>
Expand Down