Move scene param types to their respective fiat plugin scene files #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
approved these changes
Oct 3, 2024
|
Visual changes require screenshots in the PR. |
Jon-edge
requested changes
Oct 3, 2024
| @@ -123,7 +123,7 @@ export const InfoDisplayScene = React.memo((props: Props) => { | |||
| )) | |||
|
|
|||
| return ( | |||
| <SceneWrapper scroll hasNotifications> | |||
| <SceneWrapper hasTabs scroll hasNotifications> | |||
There was a problem hiding this comment.
While we're at it, fix the InfoDisplayScene using deprecated components like MainButton to use SceneButtons. This should be a primary button (which SceneButtons and all button group components enforce automatically)
There was a problem hiding this comment.
We need to have screenshots in visual PRs so reviewers can catch these mistakes easier.
Jon-edge
approved these changes
Oct 3, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: