Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature close on timeout #299

Open
wants to merge 11 commits into
base: feature-dev
Choose a base branch
from
Open

Commits on Oct 24, 2018

  1. #298 except for serverSentEvents

    - Found a case that if you slow down sse transport then both transports
    will be active causing a number of issues. Looks like we found that
    before
    - added completion block to see negotiate as well for #276
    joeldart committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    3628a5d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. #298 updating pod file, etc

    joeldart committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    041ce77 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Configuration menu
    Copy the full SHA
    81d86f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2415dc View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. expose transport for use in tests, etc.

    - by default you should not be messing with transport on the
    connection. we needed to for our use case and I could not figure out
    another way to get access to this other than exposing it.
    joeldart committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    c5b3557 View commit details
    Browse the repository at this point in the history
  2. #298 : clear out handlers when there is a completionHandler

    - sse will continue reconnecting even if the connection is no longer
    referencing the transport if you use it directly. dereference
    everything so that it will not attempt to reconnect after being stopped
    joeldart committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    5d92e47 View commit details
    Browse the repository at this point in the history
  3. prevent longPolling from running forever

    - when testing if you either timeout or abort connections (using
    fiddler or some other mitm tool) on most connections, they fallback
    regularly, but if you ever get to longPolling, it would continue
    retrying forever - even if there no connection ever comes up. This
    change checks if we are active when it gets an error in longPolling. If
    outside the reconnectWindow, it will stop the connection.
    joeldart committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    5227bd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. #300 : trigger didReconnect on initialized

    - 503 errors or firewall software, etc will hit the
    NSStreamEventOpenCompleted and thus the onOpened callback. But we do
    not want to trigger didReconnect here or else we’ll never timeout our
    reconnect. Instead, process the initialized message that is sent down.
    joeldart committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    157a780 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. #301 : move from bool to block

    - the bool was not always catching our reconnect and was a little more difficult to track what was going on. Instead store the blockoperation and cancel in the right places
    joeldart committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    09460fd View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. #300 only trigger reconnect on initialized

    - left out an important change for 300: moving the reconnect logic
    exclusively to the message + initialized loop. prior code didn’t
    actually change anything
    joeldart committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    6550e5e View commit details
    Browse the repository at this point in the history
  2. fixup tests from #300 change

    joeldart committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    f748a6c View commit details
    Browse the repository at this point in the history