Feature close on timeout #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Found a case that if you slow down sse transport then both transports will be active causing a number of issues. Looks like we found that before - added completion block to see negotiate as well for #276
- by default you should not be messing with transport on the connection. we needed to for our use case and I could not figure out another way to get access to this other than exposing it.
- sse will continue reconnecting even if the connection is no longer referencing the transport if you use it directly. dereference everything so that it will not attempt to reconnect after being stopped
- when testing if you either timeout or abort connections (using fiddler or some other mitm tool) on most connections, they fallback regularly, but if you ever get to longPolling, it would continue retrying forever - even if there no connection ever comes up. This change checks if we are active when it gets an error in longPolling. If outside the reconnectWindow, it will stop the connection.
- 503 errors or firewall software, etc will hit the NSStreamEventOpenCompleted and thus the onOpened callback. But we do not want to trigger didReconnect here or else we’ll never timeout our reconnect. Instead, process the initialized message that is sent down.
- the bool was not always catching our reconnect and was a little more difficult to track what was going on. Instead store the blockoperation and cancel in the right places
- left out an important change for 300: moving the reconnect logic exclusively to the message + initialized loop. prior code didn’t actually change anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.