Add dark theme setting for settings screen #339

yagipy · 2021-03-10T00:12:22Z

Issue

close Add dark theme setting for settings screen #279

Overview (Required)

Add dark theme setting for settings screen.
No special support is provided for devices with API level 29 or earlier.
- I believe that the power saving mode is part of the device settings.
- Therefore, I think "follow device settings" is sufficient, not "only in power saving mode".
- If necessary, I will create the issue.

Problem

The splash screen is not referencing the in-app theme. (Device settings will be referenced).
- I want you to check the reviews.
- If necessary, I will create the issue.

Links

https://github.com/DroidKaigi/conference-app-2020/pull/526/files

Screenshot

Before	After

anandwana001 · 2021-03-10T04:31:12Z

uicomponent-compose/other/src/main/java/io/github/droidkaigi/feeder/setting/SettingViewModel.kt

+import kotlinx.coroutines.flow.StateFlow
+
+interface SettingViewModel :
+    UnidirectionalViewModel<SettingViewModel.Event, SettingViewModel.Effect, SettingViewModel.State> {


Looks like we have a ktlint failure here due to chars are more than 100 in a line.
Exceeded max line length (100)
You can simply break them into multiple lines to pass the GitHub checks.

@anandwana001
Thanks, I fixed it.

takahirom · 2021-03-11T00:12:12Z

👀

takahirom

Almost LGTM! Cool 🆒

takahirom · 2021-03-11T00:53:31Z

uicomponent-compose/main/src/main/java/io/github/droidkaigi/feeder/DroidKaigiAppViewModel.kt

+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.flow.StateFlow
+
+interface DroidKaigiAppViewModel :


Currently, I don't use the name of DroidKaigi other than the theme, so I want to use AppViewModel.

takahirom · 2021-03-11T00:57:26Z

uicomponent-compose/core/src/main/java/io/github/droidkaigi/feeder/core/theme/Theme.kt

            typography = typography,
            shapes = shapes,
            content = content
        )
    }
 }

+@Composable
+private fun colorPalette(theme: Theme?): Colors {


takahirom · 2021-03-11T01:04:08Z

uicomponent-compose/core/src/main/res/values-ja/strings.xml

@@ -3,4 +3,7 @@
    <string name="error_network">ネットワークエラーが発生しました。もう一度お試しください。</string>
    <string name="error_server">サーバーエラーが発生しました。もう一度お試しください。</string>
    <string name="error_unknown">予期しないエラーが発生しました。もう一度お試しください。</string>
+    <string name="system">端末設定に従う</string>


takahirom · 2021-03-11T01:07:50Z

uicomponent-compose/other/src/main/java/io/github/droidkaigi/feeder/setting/Setting.kt

+}
+
+@Composable
+fun Theme(


How about making it private and naming it ThemeSetting, as it can be mistaken for setting Theme? 🎨

Thanks, I've changed it that way!

takahirom · 2021-03-11T01:12:04Z

Therefore, I think "follow device settings" is sufficient, not "only in power saving mode".

👍

The splash screen is not referencing the in-app them

Thank you! We will create issue!

takahirom · 2021-03-11T01:29:26Z

Sorry. Please fix conflict 🙏

yagipy · 2021-03-11T02:05:47Z

@takahirom
I fixed conflict!

We will create issue!

I created an issue!
Please check it out 🙏
#344

yagipy · 2021-03-11T02:26:11Z

Sorry, the CI is down, I'll contact you after I fix it.

yagipy · 2021-03-11T02:38:15Z

@takahirom
CI passed!
Please check it out 🙇‍♂️

takahirom

LGTM 👍 I think this is a good sample for changing the theme in app!

Add dark theme setting for settings screen

d456b6c

yagipy force-pushed the add-dark-theme-setting-for-settings-screen branch from 6c3a3b6 to d456b6c Compare March 10, 2021 00:18

Merge branch 'main' into add-dark-theme-setting-for-settings-screen

771e2c9

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 00:42 Inactive

anandwana001 suggested changes Mar 10, 2021

View reviewed changes

yagipy changed the title ~~[WIP]Add dark theme setting for settings screen~~ Add dark theme setting for settings screen Mar 10, 2021

HiroyukiYagihashi added 3 commits March 11, 2021 03:32

Modify setting screen design

2e423fe

Set default theme

daa335a

Delete unnecessary code

140ac95

yagipy marked this pull request as ready for review March 10, 2021 19:07

Merge branch 'main' into add-dark-theme-setting-for-settings-screen

96fb03a

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 19:42 Inactive

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 19:52 Inactive

yagipy force-pushed the add-dark-theme-setting-for-settings-screen branch from 58765b4 to 117ccb3 Compare March 10, 2021 19:58

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 20:05 Inactive

yagipy force-pushed the add-dark-theme-setting-for-settings-screen branch 2 times, most recently from 7718501 to 9b74b7f Compare March 10, 2021 20:18

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 20:18 Inactive

pass CI

e54d515

yagipy force-pushed the add-dark-theme-setting-for-settings-screen branch from 9b74b7f to e54d515 Compare March 10, 2021 20:24

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 20:26 Inactive

github-actions bot temporarily deployed to deploygate-distribution March 10, 2021 20:31 Inactive

takahirom reviewed Mar 11, 2021

View reviewed changes

HiroyukiYagihashi added 2 commits March 11, 2021 10:25

Change DroidKaigAppViewModel to AppViewModel

d3fe655

Change Theme Component to ThemeSetting Component

3a660a0

yagipy mentioned this pull request Mar 11, 2021

The splash screen is not referencing the in-app theme #344

Open

Merge branch 'main' into add-dark-theme-setting-for-settings-screen

9c51287

yagipy requested a review from takahirom March 11, 2021 02:06

Pass CI

df0cf66

github-actions bot temporarily deployed to deploygate-distribution March 11, 2021 02:38 Inactive

takahirom added the awesome label Mar 11, 2021

takahirom approved these changes Mar 11, 2021

View reviewed changes

takahirom merged commit 79d67aa into DroidKaigi:main Mar 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dark theme setting for settings screen #339

Add dark theme setting for settings screen #339

yagipy commented Mar 10, 2021 •

edited

Loading

anandwana001 Mar 10, 2021

yagipy Mar 10, 2021

takahirom commented Mar 11, 2021

takahirom left a comment

takahirom Mar 11, 2021

takahirom Mar 11, 2021

takahirom Mar 11, 2021

takahirom Mar 11, 2021

yagipy Mar 11, 2021

takahirom commented Mar 11, 2021

takahirom commented Mar 11, 2021

yagipy commented Mar 11, 2021 •

edited

Loading

yagipy commented Mar 11, 2021

yagipy commented Mar 11, 2021 •

edited

Loading

takahirom left a comment

Add dark theme setting for settings screen #339

Add dark theme setting for settings screen #339

Conversation

yagipy commented Mar 10, 2021 • edited Loading

Issue

Overview (Required)

Problem

Links

Screenshot

anandwana001 Mar 10, 2021

Choose a reason for hiding this comment

yagipy Mar 10, 2021

Choose a reason for hiding this comment

takahirom commented Mar 11, 2021

takahirom left a comment

Choose a reason for hiding this comment

takahirom Mar 11, 2021

Choose a reason for hiding this comment

takahirom Mar 11, 2021

Choose a reason for hiding this comment

takahirom Mar 11, 2021

Choose a reason for hiding this comment

takahirom Mar 11, 2021

Choose a reason for hiding this comment

yagipy Mar 11, 2021

Choose a reason for hiding this comment

takahirom commented Mar 11, 2021

takahirom commented Mar 11, 2021

yagipy commented Mar 11, 2021 • edited Loading

yagipy commented Mar 11, 2021

yagipy commented Mar 11, 2021 • edited Loading

takahirom left a comment

Choose a reason for hiding this comment

yagipy commented Mar 10, 2021 •

edited

Loading

yagipy commented Mar 11, 2021 •

edited

Loading

yagipy commented Mar 11, 2021 •

edited

Loading