Skip to content

Commit

Permalink
pass CI
Browse files Browse the repository at this point in the history
  • Loading branch information
HiroyukiYagihashi committed Mar 10, 2021
1 parent 96fb03a commit e54d515
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 28 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.github.droidkaigi.feeder.data

import com.russhwolf.settings.ExperimentalSettingsApi
import com.russhwolf.settings.MockSettings
import com.russhwolf.settings.coroutines.FlowSettings
import com.russhwolf.settings.coroutines.toFlowSettings
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.github.droidkaigi.feeder.data

import io.github.droidkaigi.feeder.repository.ThemeRepository
import javax.inject.Inject
import javax.inject.Singleton

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package io.github.droidkaigi.feeder.repository

import io.github.droidkaigi.feeder.FeedContents
import io.github.droidkaigi.feeder.FeedItem
import io.github.droidkaigi.feeder.Theme
import kotlinx.coroutines.flow.Flow

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import io.github.droidkaigi.feeder.core.ScrollableTabRow
import io.github.droidkaigi.feeder.core.TabIndicator
import io.github.droidkaigi.feeder.core.TabRowDefaults.tabIndicatorOffset
import io.github.droidkaigi.feeder.core.animation.FadeThrough
import io.github.droidkaigi.feeder.Theme
import io.github.droidkaigi.feeder.core.getReadableMessage
import io.github.droidkaigi.feeder.core.theme.AppThemeWithBackground
import io.github.droidkaigi.feeder.core.use
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.alpha
import androidx.lifecycle.viewmodel.compose.viewModel
import dev.chrisbanes.accompanist.insets.navigationBarsPadding
import io.github.droidkaigi.feeder.core.theme.ConferenceAppFeederTheme
import io.github.droidkaigi.feeder.core.use
import io.github.droidkaigi.feeder.viewmodel.RealDroidKaigiAppViewModel

@Composable
fun DroidKaigiApp(firstSplashScreenState: SplashState = SplashState.Shown) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ private val LocalDroidKaigiAppViewModel = compositionLocalOf<DroidKaigiAppViewMo
}

@Composable
fun ProvideDroidKaigiAppViewModel(viewModel: DroidKaigiAppViewModel, block: @Composable () ->
Unit) {
fun ProvideDroidKaigiAppViewModel(
viewModel: DroidKaigiAppViewModel,
block: @Composable () -> Unit
) {
CompositionLocalProvider(LocalDroidKaigiAppViewModel provides viewModel, content = block)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ package io.github.droidkaigi.feeder.viewmodel

import androidx.compose.runtime.Composable
import androidx.lifecycle.viewmodel.compose.viewModel
import io.github.droidkaigi.feeder.ProvideDroidKaigiAppViewModel
import io.github.droidkaigi.feeder.contributor.ProvideContributorViewModel
import io.github.droidkaigi.feeder.contributor.fakeContributorViewModel
import io.github.droidkaigi.feeder.ProvideDroidKaigiAppViewModel
import io.github.droidkaigi.feeder.feed.ProvideFeedViewModel
import io.github.droidkaigi.feeder.setting.ProvideSettingViewModel
import io.github.droidkaigi.feeder.staff.ProvideStaffViewModel
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,14 @@ import androidx.lifecycle.viewModelScope
import dagger.hilt.android.lifecycle.HiltViewModel
import io.github.droidkaigi.feeder.DroidKaigiAppViewModel
import io.github.droidkaigi.feeder.repository.ThemeRepository
import io.github.droidkaigi.feeder.setting.SettingViewModel
import io.github.droidkaigi.feeder.staff.StaffViewModel
import javax.inject.Inject
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.flow.stateIn
import kotlinx.coroutines.launch
import javax.annotation.meta.Exhaustive
import javax.inject.Inject

@HiltViewModel
class RealDroidKaigiAppViewModel @Inject constructor(
Expand All @@ -26,14 +22,12 @@ class RealDroidKaigiAppViewModel @Inject constructor(
override val effect: Flow<DroidKaigiAppViewModel.Effect> = effectChannel.receiveAsFlow()

override val state: StateFlow<DroidKaigiAppViewModel.State> =
repository.theme().map { DroidKaigiAppViewModel.State(theme = it)}
repository.theme().map { DroidKaigiAppViewModel.State(theme = it) }
.stateIn(
scope = viewModelScope,
started = SharingStarted.Eagerly,
initialValue = DroidKaigiAppViewModel.State()
)

override fun event(event: DroidKaigiAppViewModel.Event) {
TODO("Not yet implemented")
}
override fun event(event: DroidKaigiAppViewModel.Event) {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ package io.github.droidkaigi.feeder.viewmodel

import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import app.cash.exhaustive.Exhaustive
import dagger.hilt.android.lifecycle.HiltViewModel
import io.github.droidkaigi.feeder.setting.SettingViewModel
import io.github.droidkaigi.feeder.repository.ThemeRepository
import io.github.droidkaigi.feeder.setting.SettingViewModel
import javax.inject.Inject
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.Flow
Expand All @@ -14,7 +15,6 @@ import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.flow.stateIn
import kotlinx.coroutines.launch
import javax.annotation.meta.Exhaustive

@HiltViewModel
class RealSettingViewModel @Inject constructor(
Expand All @@ -24,7 +24,7 @@ class RealSettingViewModel @Inject constructor(
override val effect: Flow<SettingViewModel.Effect> = effectChannel.receiveAsFlow()

override val state: StateFlow<SettingViewModel.State> =
repository.theme().map { SettingViewModel.State(theme = it)}
repository.theme().map { SettingViewModel.State(theme = it) }
.stateIn(
scope = viewModelScope,
started = SharingStarted.Eagerly,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,23 +54,22 @@ fun Settings() {
}
}


@Composable
fun Theme(
context: Context,
theme: Theme?,
onClick: (Theme?) -> Unit
) {
val openDialog = remember { mutableStateOf(false) }
val openDialog = remember { mutableStateOf(false) }
Row(
verticalAlignment = Alignment.CenterVertically,
modifier = Modifier
.clickable {
openDialog.value = true
}
openDialog.value = true
}
.fillMaxWidth()
.padding(vertical = 24.dp)
){
) {
Text(
text = "Theme",
style = typography.h5,
Expand Down Expand Up @@ -133,7 +132,7 @@ fun ThemeSelectRadioButton(
context: Context
) {
val themes: List<Theme> = Theme.values().toList()
var defaultIndex = 0;
var defaultIndex = 0
themes.forEachIndexed { index, it -> if (it == theme) defaultIndex = index }
val (selectedTheme, oThemeSelected) = remember { mutableStateOf(themes[defaultIndex]) }
Column(
Expand Down

0 comments on commit e54d515

Please sign in to comment.