Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParU: Avoid overlinking #487

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mmuetzel
Copy link
Contributor

ParU itself doesn't depend on CHOLMOD. Only the demos do. Similar to #479.

Also fix a copy-paste error.

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Nov 1, 2023

ParU doesn't need to link to the CHOLMOD library. It does include its header though.
Should be fixed now.

@DrTimothyAldenDavis
Copy link
Owner

As long as ParU can find the cholmod.h header file, I see that the ParU library itself doesn't need to link against CHOLMOD itself.

So the find_package (CHOLMOD 5.0.0) is still there, so it can find the right cholmod.h, but then the linking can skip CHOLMOD, right?

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 88bfdce into DrTimothyAldenDavis:dev2 Nov 1, 2023
17 checks passed
@mmuetzel
Copy link
Contributor Author

mmuetzel commented Nov 1, 2023

So the find_package (CHOLMOD 5.0.0) is still there, so it can find the right cholmod.h, but then the linking can skip CHOLMOD, right?

Exactly. That is needed when building ParU before CHOLMOD is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants