Merge pull request #487 from mmuetzel/paru

ParU: Avoid overlinking
DrTimothyAldenDavis · Nov 1, 2023 · 88bfdce · 88bfdce
2 parents f310c01 + 1d5e7e5
commit 88bfdce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/ParU/CMakeLists.txt b/ParU/CMakeLists.txt
@@ -219,15 +219,11 @@ if ( NOT NSTATIC )
 endif ( )
 
 # cholmod:
-target_link_libraries ( ParU PRIVATE SuiteSparse::CHOLMOD )
 target_include_directories ( ParU PUBLIC
     "$<TARGET_PROPERTY:SuiteSparse::CHOLMOD,INTERFACE_INCLUDE_DIRECTORIES>" )
 if ( NOT NSTATIC )
-    if ( TARGET SuiteSparse::CHOLMOD_static )
-        target_link_libraries ( ParU_static PUBLIC SuiteSparse::CHOLMOD_static )
-    else ( )
-        target_link_libraries ( ParU_static PUBLIC SuiteSparse::CHOLMOD )
-    endif ( )
+    target_include_directories ( ParU_static PUBLIC
+        "$<TARGET_PROPERTY:SuiteSparse::CHOLMOD,INTERFACE_INCLUDE_DIRECTORIES>" )
 endif ( )
 
 #-------------------------------------------------------------------------------

diff --git a/ParU/Config/ParU.pc.in b/ParU/Config/ParU.pc.in
@@ -11,7 +11,7 @@ Name: ParU
 URL: https://github.com/DrTimothyAldenDavis/SuiteSparse
 Description: Routines for solving sparse linear system via parallel multifrontal LU factorization algorithms in SuiteSparse
 Version: @PARU_VERSION_MAJOR@.@PARU_VERSION_MINOR@.@PARU_VERSION_UPDATE@
-Requires.private: SuiteSparse_config CHOLMOD UMFPACK
+Requires.private: SuiteSparse_config UMFPACK
 Libs: -L${libdir} -lparu
 Libs.private: @PARU_STATIC_LIBS@
 Cflags: -I${includedir}