LDL: Avoid overlinking #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point. Yes, ldl itself doesn't call AMD, just the demo program does. |
DrTimothyAldenDavis
merged commit 39d2bef
into
DrTimothyAldenDavis:dev2
17 checks passed
This was referenced Oct 31, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ldl library doesn't actually depend on libsuitesparseconfig or libamd. Only some of the demos do and some preprocessor definition from the SuiteSparse_config header are used in some compilation units.
Avoid overlinking that library to the libraries that it doesn't use.
Also avoid inclusion of a header inside an
extern "C"block.