Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Use SUITESPARSE_INCLUDEDIR in more places. #364

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

mmuetzel
Copy link
Contributor

Also, don't double quote generator expressions. (I don't recall why I did that in the first place...)

The remaining place where CMAKE_INSTALL_INCLUDEDIR is still used is in GraphBLAS/cpu_features/CMakeLists.txt. I'm not sure what that is and left it alone.

Also, don't double quote generator expressions.
@DrTimothyAldenDavis
Copy link
Owner

The cpu_features folder is an exact copy of the original Google repo for that package, but I don't use the cpu_features build system itself to create a cpu_features library. I compile the code from the GraphBLAS cmake. So the cpu_features/CMakeLists.txt file is unused. Same thing with CHOLMOD/SuiteSparse_metis/CMakelists.txt

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Aug 30, 2023

So the cpu_features/CMakeLists.txt file is unused.

In that case, the changes from this PR should be complete when it comes to the include directory in the interface of the CMake targets.

@DrTimothyAldenDavis
Copy link
Owner

Looks good.

Removing the extraneous double quotes is a good idea. I was confused by them since the spurious report from SuiteSparse_GPURuntime had no double quotes but the other places had it, so I thought that error was from missing a required double quote.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit a2e9a62 into DrTimothyAldenDavis:dev2 Aug 30, 2023
13 checks passed
@DrTimothyAldenDavis
Copy link
Owner

Works great -- thanks! The Example package now compiles on my desktop when using CUDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants