CMake: Use SUITESPARSE_INCLUDEDIR in even more places.
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, don't double quote generator expressions.
|
Thanks -- I'll give it a try. |
DrTimothyAldenDavis
merged commit a6dd4c4
into
DrTimothyAldenDavis:dev2
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, don't double quote generator expressions.
Those are some instances that I missed in #364.
I'm pretty sure that I grepped for
CMAKE_INSTALL_INCLUDEDIRwhen I made those changes. But my concentration might have been low (late evening here)…