-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XBPM feedback for i03 #160
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
903c67b
(DiamondLightSource/hyperion#796) Add feedback check for i03
DominicOram a5f22b8
Merge branch 'main' into hyperion_796_xbpm_feedback
DominicOram 7da81e4
(DiamondLightSource/hyperion#796) Update ophyd dependency
DominicOram b899b9c
Merge branch '141_i04_devices' into hyperion_796_xbpm_feedback
DominicOram 54ef30f
(DiamondLightSource/hyperion#796) Update comment on how xbpm works
DominicOram 431065c
Merge branch 'main' into hyperion_796_xbpm_feedback
DominicOram f2677a2
(#796) Use stable PV rather than work it out ourselves
DominicOram af63f5c
Merge branch 'main' into hyperion_796_xbpm_feedback
DominicOram 1d9100f
Merge branch 'main' into hyperion_796_xbpm_feedback
DominicOram 3d2a48e
Fixed signature
DominicOram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit, ignorable]
I know this is technically correct but maybe it would be clearer to use the exact signature advised in the ophyd docs?