-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XBPM feedback for i03 #160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 89.50% 89.54% +0.03%
==========================================
Files 71 71
Lines 2430 2438 +8
==========================================
+ Hits 2175 2183 +8
Misses 255 255
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just one more substantive comment I noticed...
From https://jira.diamond.ac.uk/browse/I03-870 it looks like the stability check is no longer needed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion, feel free to ignore and merge this if you like. Otherwise LGTM.
src/dodal/devices/xbpm_feedback.py
Outdated
status = StableSubscriptionStatus( | ||
self.pos_ok, | ||
return SubscriptionStatus( | ||
self.pos_stable, | ||
lambda value, *args, **kwargs: value == 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit, ignorable]
I know this is technically correct but maybe it would be clearer to use the exact signature advised in the ophyd docs?
Merge #142 first.
Needed for DiamondLightSource/hyperion#796