Add XBPM feedback for i03 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 89.50% 89.54% +0.03%
==========================================
Files 71 71
Lines 2430 2438 +8
==========================================
+ Hits 2175 2183 +8
Misses 255 255
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
From https://jira.diamond.ac.uk/browse/I03-870 it looks like the stability check is no longer needed in |
Tom-Willemsen
approved these changes
Sep 11, 2023
Tom-Willemsen
approved these changes
Sep 14, 2023
src/dodal/devices/xbpm_feedback.py
Outdated
| status = StableSubscriptionStatus( | ||
| self.pos_ok, | ||
| return SubscriptionStatus( | ||
| self.pos_stable, | ||
| lambda value, *args, **kwargs: value == 1, |
There was a problem hiding this comment.
[nit, ignorable]
I know this is technically correct but maybe it would be clearer to use the exact signature advised in the ophyd docs?
Tom-Willemsen
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #142 first.
Needed for DiamondLightSource/hyperion#796