Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document listener #329
Add document listener #329
Changes from 5 commits
457edea
8565e0b
904a9bf
f92fd9a
983cdba
f158291
7087585
9d2bf10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources should be much smaller than the resources for the blueapi main container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just remove the resource requirements entirely and let k8s work it out. Do you think that's reasonable?
The alternative is including a listener.resources section in the values.yaml which I don't know if we should do since it's such a small process
Check warning on line 62 in src/blueapi/cli/amq.py
Codecov / codecov/patch
src/blueapi/cli/amq.py#L62
Check warning on line 138 in src/blueapi/cli/cli.py
Codecov / codecov/patch
src/blueapi/cli/cli.py#L137-L138
Check warning on line 140 in src/blueapi/cli/cli.py
Codecov / codecov/patch
src/blueapi/cli/cli.py#L140
Check warning on line 145 in src/blueapi/cli/cli.py
Codecov / codecov/patch
src/blueapi/cli/cli.py#L144-L145
Check warning on line 147 in src/blueapi/cli/cli.py
Codecov / codecov/patch
src/blueapi/cli/cli.py#L147
Check warning on line 153 in src/blueapi/cli/cli.py
Codecov / codecov/patch
src/blueapi/cli/cli.py#L151-L153