Add document listener #329
Conversation
src/blueapi/cli/cli.py
Outdated
| print(f"Subscribing to all bluesky events from {config.stomp.host}:{config.stomp.port}") | ||
| with amq_client: | ||
| amq_client.subscribe_to_all_events(on_event) | ||
| input() |
There was a problem hiding this comment.
Is it worth adding a message along the lines of 'Press enter to exit'?
There was a problem hiding this comment.
Wonderfully paradoxical sentence but yes
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
- Coverage 87.06% 86.57% -0.50%
==========================================
Files 41 41
Lines 1531 1549 +18
==========================================
+ Hits 1333 1341 +8
- Misses 198 208 +10
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
callumforrester
force-pushed
the
doc-listener
branch
from
47b0671
to
f92fd9a
Compare
| resources: | ||
| {{- toYaml .Values.resources | nindent 12 }} |
There was a problem hiding this comment.
Resources should be much smaller than the resources for the blueapi main container
There was a problem hiding this comment.
I'll just remove the resource requirements entirely and let k8s work it out. Do you think that's reasonable?
The alternative is including a listener.resources section in the values.yaml which I don't know if we should do since it's such a small process
|
I don't particularly care that codecov is failing. Writing an integration test for this sort of thing is hard, because we need a test that simultaneously; 1. puts things on the message bus and 2.listens to it. This can be a ticket for later, but for now I'm happy to merge this. |
Chagnes: