Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sampling): add rc for trace sampling rules #8900

Merged
merged 44 commits into from
Apr 30, 2024
Merged

chore(sampling): add rc for trace sampling rules #8900

merged 44 commits into from
Apr 30, 2024

Commits on Mar 29, 2024

  1. add parsing method for rc sampling rules and change the config object… 

    … to change the rules
    @ZStriker19
    ZStriker19 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b9f64ca View commit details
    Browse the repository at this point in the history

  2. add test cases for invalid rules

    @ZStriker19
    ZStriker19 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5308104 View commit details
    Browse the repository at this point in the history

  3. add rc wiring

    @ZStriker19
    ZStriker19 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    bf4e9e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f1faed6 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7741092 View commit details
    Browse the repository at this point in the history

  2. fix recursion bug

    @ZStriker19
    ZStriker19 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1b326d0 View commit details
    Browse the repository at this point in the history

  3. add to telemetry

    @ZStriker19
    ZStriker19 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    cc231c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. try to fix logic for handling only new sample_rate or only new sampli… 

    …ng_rules
    @ZStriker19
    ZStriker19 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    51ab94d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e373478 View commit details
    Browse the repository at this point in the history

  3. fix logic for sampler creation

    @ZStriker19
    ZStriker19 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f13c56c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. current rc tests passing and sampler logic seems sound

    @ZStriker19
    ZStriker19 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ff47b18 View commit details
    Browse the repository at this point in the history

  2. small fixes, touch DatadogSampler, add rc sampling_rules test

    @ZStriker19
    ZStriker19 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    00cb433 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    68d940a View commit details
    Browse the repository at this point in the history

  4. add in provenance for rules

    @ZStriker19
    ZStriker19 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3f74021 View commit details
    Browse the repository at this point in the history

  5. add comma per rule for str, add capability

    @ZStriker19
    ZStriker19 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ef351f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. order rules by provenance

    @ZStriker19
    ZStriker19 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    d322976 View commit details
    Browse the repository at this point in the history

  2. tiny touch ups to parser documentation

    @ZStriker19
    ZStriker19 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    44dcef8 View commit details
    Browse the repository at this point in the history

  3. don't trim trailing comma in parser

    @ZStriker19
    ZStriker19 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    5bb0929 View commit details
    Browse the repository at this point in the history

  4. Revert "don't trim trailing comma in parser" 

    This reverts commit 5bb0929.
    @ZStriker19
    ZStriker19 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    552e68a View commit details
    Browse the repository at this point in the history

  5. make parser way simpler

    @ZStriker19
    ZStriker19 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    cb65399 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. test behavior of modifying tracing_sampling_rules and tracing_samplin… 

    …g_rate at different times, making sure they revert properly
    @ZStriker19
    ZStriker19 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d53adb3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9a1b0b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix parsing code and tests

    @ZStriker19
    ZStriker19 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9e5fbf7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    910c9cf View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    96ff5b3 View commit details
    Browse the repository at this point in the history

  2. update capabilities test, update debug test with provenance

    @ZStriker19
    ZStriker19 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    34e1821 View commit details
    Browse the repository at this point in the history

  3. fix telemetry writer tests

    @ZStriker19
    ZStriker19 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    58f4125 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    44c4aa7 View commit details
    Browse the repository at this point in the history

  5. change default

    @ZStriker19
    ZStriker19 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b8fce94 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. attempt telemetry writer fix

    @ZStriker19
    ZStriker19 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4ca0a3f View commit details
    Browse the repository at this point in the history

  2. update _dd.p.dm values

    @ZStriker19
    ZStriker19 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    afbd240 View commit details
    Browse the repository at this point in the history

  3. update _dd.p.dm values

    @ZStriker19
    ZStriker19 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    efffa3a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fa84b1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0ae1a4c View commit details
    Browse the repository at this point in the history

  3. fix telemetry writer tests

    @ZStriker19
    ZStriker19 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    197b1ac View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0c440d1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e0ae1c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fa806ca View commit details
    Browse the repository at this point in the history

  2. Update tests/internal/remoteconfig/test_remoteconfig.py 

    Co-authored-by: Emmett Butler <[email protected]>
    @ZStriker19 @emmettbutler
    ZStriker19 and emmettbutler authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c1b49ed View commit details
    Browse the repository at this point in the history

  3. Update ddtrace/settings/config.py 

    Co-authored-by: Emmett Butler <[email protected]>
    @ZStriker19 @emmettbutler
    ZStriker19 and emmettbutler authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    159ac00 View commit details
    Browse the repository at this point in the history

  4. Update ddtrace/settings/config.py 

    Co-authored-by: Emmett Butler <[email protected]>
    @ZStriker19 @emmettbutler
    ZStriker19 and emmettbutler authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3fc5773 View commit details
    Browse the repository at this point in the history

  5. refactoring

    @ZStriker19
    ZStriker19 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6c6a2e0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a719fa0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into zachg/add_rcm_for_trace_sampling_rules

    @ZStriker19
    ZStriker19 authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8d2f553 View commit details
    Browse the repository at this point in the history