-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sampling): add rc for trace sampling rules #8900
Conversation
… to change the rules
Datadog ReportBranch report: ✅ 0 Failed, 131616 Passed, 42229 Skipped, 6h 2m 38.51s Total duration (4h 20m 5.62s time saved) ⌛ Performance Regressions vs Default Branch (1)
|
BenchmarksBenchmark execution time: 2024-04-30 18:42:23 Comparing candidate commit 3fc5773 in PR branch Found 9 performance improvements and 10 performance regressions! Performance is the same for 182 metrics, 9 unstable metrics. scenario:flasksimple-appsec-get
scenario:httppropagationextract-full_t_id_datadog_headers
scenario:httppropagationextract-invalid_trace_id_header
scenario:httppropagationextract-valid_headers_all
scenario:httppropagationextract-wsgi_large_header_no_matches
scenario:httppropagationextract-wsgi_medium_header_no_matches
scenario:httppropagationextract-wsgi_valid_headers_basic
scenario:sethttpmeta-all-disabled
scenario:sethttpmeta-all-enabled
scenario:sethttpmeta-obfuscation-disabled
scenario:sethttpmeta-obfuscation-regular-case-explicit-query
scenario:sethttpmeta-obfuscation-regular-case-implicit-query
scenario:sethttpmeta-useragentvariant_exists_1
scenario:sethttpmeta-useragentvariant_exists_2
scenario:sethttpmeta-useragentvariant_exists_3
scenario:sethttpmeta-useragentvariant_not_exists_1
scenario:span-start-finish
scenario:tracer-large
scenario:tracer-small
|
1024978
to
51ab94d
Compare
This reverts commit 5bb0929.
…g_rate at different times, making sure they revert properly
de08f30
to
9e5fbf7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8900 +/- ##
===========================================
- Coverage 68.03% 6.58% -61.45%
===========================================
Files 1266 1236 -30
Lines 119540 117846 -1694
===========================================
- Hits 81328 7762 -73566
- Misses 38212 110084 +71872 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Emmett Butler <[email protected]>
Co-authored-by: Emmett Butler <[email protected]>
Co-authored-by: Emmett Butler <[email protected]>
This PR implements remote config for
DD_TRACE_SAMPLING_RULES
:provenance
which we parse from rc and use to give a new decision maker_dd.p.dm
to either-11
forcustomer
configuration or-12
fordynamic
configuration.In addition to the sample_rate we already had I added one for sampling_rules and for the interaction between them. This PR also passes the newly added system-tests for this behavior.
Since this feature is in internal beta, there's no release note.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist