Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiling): reduce lock profiler log spam #11377

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix(profiling): reduce lock profiler log spam #11377

merged 3 commits into from
Nov 13, 2024
+9 −2

Commits on Nov 13, 2024

  1. fix(profiling): reduce lock profiler log spam 

    The lock profiler would log a warning if it couldn't determine a name
for a lock. This lead to excessive log spam. Downgrade this to a debug
log.
    @nsrip-dd
    nsrip-dd committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    01aacf0 View commit details
    Browse the repository at this point in the history

  2. fix(profiling): only do the lock name check once 

    We check "if self._self_name" to avoid setting the name more than once,
but that will evaluate to false for `self._self_name == ""`, so we do
the name check every time even if we failed the first time.
    @nsrip-dd
    nsrip-dd committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5a50c85 View commit details
    Browse the repository at this point in the history

  3. chore: update release note

    @nsrip-dd
    nsrip-dd committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f6fb08c View commit details
    Browse the repository at this point in the history