fix(profiling): reduce lock profiler log spam #11377
Conversation
The lock profiler would log a warning if it couldn't determine a name for a lock. This lead to excessive log spam. Downgrade this to a debug log.
|
|
taegyunkim
added
Profiling
We check "if self._self_name" to avoid setting the name more than once, but that will evaluate to false for `self._self_name == ""`, so we do the name check every time even if we failed the first time.
|
Thank you for the fix! |
BenchmarksBenchmark execution time: 2024-11-13 15:38:04 Comparing candidate commit f6fb08c in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 387 metrics, 2 unstable metrics. scenario:iast_aspects-ospathnormcase_aspect
|
|
/merge |
Devflow running:
|
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
and removed
mergequeue-status: rejected
labels
dd-devflow
bot
added
mergequeue-status: in_progress
mergequeue-status: rejected
and removed
mergequeue-status: queued
mergequeue-status: in_progress
labels
|
/merge |
Devflow running:
|
|
For those watching at home, I've tried the merge queue 3 times and it's failed for different reasons each time :( I'm just going to squash and merge, I'm reasonably confident that the failures are not related to this change. |
The lock profiler would log a warning if it couldn't determine a name for a lock, and it would try determining a name multiple times for the same lock. This lead to excessive log spam. Downgrade this to a debug log and only try to determine the name once. (cherry picked from commit 079e478)
The lock profiler would log a warning if it couldn't determine a name for a lock, and it would try determining a name multiple times for the same lock. This lead to excessive log spam. Downgrade this to a debug log and only try to determine the name once. (cherry picked from commit 079e478)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport-11377-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 079e4789ccd86b1aa567238d525ba45c1cedce56
# Push it to GitHub
git push --set-upstream origin backport-11377-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport-11377-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 079e4789ccd86b1aa567238d525ba45c1cedce56
# Push it to GitHub
git push --set-upstream origin backport-11377-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17Then, create a pull request where the |
Backport 079e478 from #11377 to 2.16. The lock profiler would log a warning if it couldn't determine a name for a lock, and it would try determining a name multiple times for the same lock. This lead to excessive log spam. Downgrade this to a debug log and only try to determine the name once. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) PROF-10898 Co-authored-by: Nick Ripley <[email protected]> Co-authored-by: Taegyun Kim <[email protected]>
Backport 079e478 from #11377 to 2.15. The lock profiler would log a warning if it couldn't determine a name for a lock, and it would try determining a name multiple times for the same lock. This lead to excessive log spam. Downgrade this to a debug log and only try to determine the name once. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) PROF-10898 Co-authored-by: Nick Ripley <[email protected]>
The lock profiler would log a warning if it couldn't determine a
name for a lock, and it would try determining a name multiple times for
the same lock. This lead to excessive log spam. Downgrade this to a
debug log and only try to determine the name once.
Checklist
Reviewer Checklist
PROF-10898