Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llmobs): recreate writer on fork [backport 2.12] #10330

Merged
merged 2 commits into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. fix(llmobs): recreate writer on fork (#10249)

    This PR ensures that the LLMObsSpanWriter is correctly recreated and
    restarted on a forked process.
    
    Previously, on a process fork we were not recreating/restarting the
    writer worker correctly. This resulted in situations with using
    celery/gunicorn where LLMObs spans were created, but never submitted as
    the forked worker process did not have a running writer thread.
    
    ## Checklist
    - [x] PR author has checked that all the criteria below are met
    - The PR description includes an overview of the change
    - The PR description articulates the motivation for the change
    - The change includes tests OR the PR description describes a testing
    strategy
    - The PR description notes risks associated with the change, if any
    - Newly-added code is easy to change
    - The change follows the [library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    - The change includes or references documentation updates if necessary
    - Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    
    ## Reviewer Checklist
    - [x] Reviewer has checked that all the criteria below are met
    - Title is accurate
    - All changes are related to the pull request's stated goal
    - Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes
    - Testing strategy adequately addresses listed risks
    - Newly-added code is easy to change
    - Release note makes sense to a user of the library
    - If necessary, author has acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment
    - Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    
    ---------
    
    Co-authored-by: Sam Brenner <[email protected]>
    (cherry picked from commit 64b5804)
    Yun-Kim authored and github-actions[bot] committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c7e23cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f308f2d View commit details
    Browse the repository at this point in the history