-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCJ-400: Update logback versions #2377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's frustrating!
<version>${logback.version}</version> | ||
<groupId>ch.qos.logback.access</groupId> | ||
<artifactId>common</artifactId> | ||
<version>2.0.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this is hardcoded now, rather than referencing the variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions are different now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay, I see. So the specific module is referenced separately. That's really frustrating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a very non-standard way to do things - not sure why they took this approach.
<version>${logback.version}</version> | ||
<groupId>ch.qos.logback.access</groupId> | ||
<artifactId>common</artifactId> | ||
<version>2.0.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay, I see. So the specific module is referenced separately. That's really frustrating.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-400
Summary
Logback changed the location of the access module which dependabot can't fix.
See also: DataBiosphere/consent-ontology#980
Have you read CONTRIBUTING.md lately? If not, do that first.