Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCJ-400: Update logback versions #2377

Merged
merged 1 commit into from
Aug 19, 2024
Merged

DCJ-400: Update logback versions #2377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<maven.compiler.target>21</maven.compiler.target>
<liquibase.version>4.29.1</liquibase.version>
<dropwizard.version>4.0.4</dropwizard.version>
<logback.version>1.4.14</logback.version>
<logback.version>1.5.7</logback.version>
<pact.version>4.6.13</pact.version>
<postgres.version>42.7.3</postgres.version>
<surefire.version>3.3.1</surefire.version>
Expand Down Expand Up @@ -547,10 +547,11 @@
</dependency>

<!-- Security update. See https://broadworkbench.atlassian.net/browse/DUOS-2826 -->
<!-- Logback Access module moved to new location. See https://logback.qos.ch/news.html -->
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-access</artifactId>
<version>${logback.version}</version>
<groupId>ch.qos.logback.access</groupId>
<artifactId>common</artifactId>
<version>2.0.3</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is hardcoded now, rather than referencing the variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions are different now

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay, I see. So the specific module is referenced separately. That's really frustrating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a very non-standard way to do things - not sure why they took this approach.

</dependency>
<!-- Security update. See https://broadworkbench.atlassian.net/browse/DUOS-2826 -->
<dependency>
Expand Down
Loading