Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECOMMONS-1548 - fix for hamburger menu not working in mobile firefox/safari #2471

Closed
wants to merge 87 commits into from

Conversation

bmckinney
Copy link

References

Description

Enables use of hamburger menu for mobile firefox/safari

Instructions for Reviewers

Resize firefox and safari to mobile and test opening and selecting items in the hamburger menu.

List of changes in this PR:

  • width changed from percent to vw
  • position: absolute removed since it prevented mobile safari from rendering, doesn't break other browsers

To test iPhone via playwright:

import { test, devices } from '@playwright/test';

test.use({
    ...devices['iPhone 13 Pro'],
    locale: 'en-US',
})

test('Mobile hamburger nav', async ({ page }) => {
    await page.goto('http://localhost:4000/home');
    await page.locator('body > ds-app > ds-themed-root > ds-root > div > div > ds-themed-header-navbar-wrapper > ds-header-navbar-wrapper > div > ds-themed-header > ds-header > header > nav > div.d-flex.flex-grow-1.ml-auto.justify-content-end.align-items-center > div > button').click();
    await page.locator('#browseDropdown').click();
    await page.locator('#collapsingNav > ul > li:nth-child(2) > ds-expandable-navbar-section > div > ul > ds-link-menu-item:nth-child(5) > a').click();
    await page.screenshot({ path: 'hamburger-nav-iphone.png' });
});

BrandonKowalski and others added 30 commits July 6, 2022 19:27
@bmckinney
Copy link
Author

sorry, pushed this to the wrong origin!

@bmckinney bmckinney deleted the ECOMMONS-1548 branch August 30, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants