Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECOMMONS-1548 - fix for hamburger menu not working in mobile firefox/safari #2471

Closed
wants to merge 87 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
d1c4366
Login components
BrandonKowalski Jul 6, 2022
4f9d95b
Update ecommons theme for 7.3
BrandonKowalski Jul 6, 2022
cf85f58
ECOMMONS-1456: fix mobile header menu
mhk33 Jul 11, 2022
b97a69a
Put back CUL header colors and update mobile logo height
mhk33 Jul 11, 2022
d9e6e2d
Update link colors so they are consistent
mhk33 Jul 14, 2022
29aac2e
ECOMMONS-1447: add About menu to footer
mhk33 Jul 14, 2022
0052b99
ECOMMONS-1459: update ecommons branding so it appears on all pages
mhk33 Aug 18, 2022
923cba2
ECOMMONS-1458: update branding and header for mobile
mhk33 Sep 27, 2022
2d02296
ECOMMONS-1458: remove dspace logo from login and logout templates
mhk33 Sep 27, 2022
d8be23d
ECOMMONS-1458: update several labels
mhk33 Sep 27, 2022
7114d16
ECOMMONS-1423: add ILR theme (work in progress)
mhk33 Oct 4, 2022
e248de3
ECOMMONS-1448: go back to default one column display for home page co…
mhk33 Nov 14, 2022
419614a
Merge branch 'DSpace:main' into main
BrandonKowalski Nov 14, 2022
870b2e4
ECOMMONS-1448: display recently added on the home page in one column
mhk33 Nov 14, 2022
b8c7681
Update home news links
mhk33 Nov 15, 2022
e64451b
ECOMMONS-1450: add h1 heading
mhk33 Nov 15, 2022
2a1e1c8
Fix for ILR theme
BrandonKowalski Dec 13, 2022
87f9b15
ECOMMONS-1205: add link to contact form; change form labels
mhk33 Dec 15, 2022
2523972
Fix browse by type missing I18N
BrandonKowalski Jan 23, 2023
b53670e
Merge remote-tracking branch 'origin/main'
BrandonKowalski Jan 23, 2023
0653084
ECOMMONS-1477: library brand should be in an aria landmark
mhk33 Jan 24, 2023
bdcbda1
ECOMMONS-1451: branding in aria landmark; better ILR brand responsive…
mhk33 Jan 24, 2023
02f0234
ECOMMONS-1478: tweak position of home page image
mhk33 Jan 27, 2023
8357830
Add new fields to simple item template test
BrandonKowalski Jan 30, 2023
2e4fc97
Merge remote-tracking branch 'origin/main'
BrandonKowalski Jan 30, 2023
1086328
Mismatched html tags fix
BrandonKowalski Jan 30, 2023
117bf15
Missing single quote
BrandonKowalski Jan 30, 2023
f337da8
Add ILR CLA fields
BrandonKowalski Jan 31, 2023
b2d0314
Adding more fields
BrandonKowalski Jan 31, 2023
de299f0
Fix single quote
BrandonKowalski Feb 1, 2023
3e6faeb
Remainder of variables to expose on simple item page
BrandonKowalski Feb 1, 2023
4cac970
Merge in 7.5
BrandonKowalski Feb 17, 2023
cc8cf12
Merge pull request #4 from DSpace/main
BrandonKowalski Mar 13, 2023
e4cfc5a
Update stale theme files
BrandonKowalski Mar 13, 2023
bc3edfd
Remove unused theme files
BrandonKowalski Mar 13, 2023
93ce216
Add custom header back
BrandonKowalski Mar 13, 2023
acbdfdd
Fix theme header after 7.5 upgrade
mhk33 Mar 21, 2023
8fa2ee9
Updates to ILR theme for 7.5 upgrade
mhk33 Mar 21, 2023
202b404
Add help link in login menu
mhk33 Mar 22, 2023
8ce377d
Iterating on submission form
BrandonKowalski Mar 24, 2023
88734a6
Add Katura support
BrandonKowalski Apr 18, 2023
150350b
Add readership Map to ILR
BrandonKowalski Apr 28, 2023
80f52bd
Hide local login elements
BrandonKowalski May 19, 2023
2934690
Attempt to add fullname to feedback form.
BrandonKowalski May 23, 2023
757756c
Rollback feedback form changes
BrandonKowalski May 23, 2023
89252a2
Fix missing fields issue
BrandonKowalski May 23, 2023
d243f16
Fix missing additional fields from "simple" page
BrandonKowalski May 24, 2023
fbc4c3e
Move full page button on simple view page
BrandonKowalski May 24, 2023
e3bc7f6
Put DOI first
BrandonKowalski May 24, 2023
5dd96f4
Put DOI first
BrandonKowalski May 24, 2023
2ac5e7d
Attempt #5 item page layout
BrandonKowalski May 24, 2023
720d0e7
Forgot to move collections to left hand side....
BrandonKowalski May 24, 2023
4b9b7c7
Remove gap in metadata
BrandonKowalski May 25, 2023
17798e8
ECOMMONS-1503: fix width of header for mobile devices
mhk33 May 30, 2023
25cfd91
ECOMMONS-1502: update help link, improve responsive for home page tex…
mhk33 May 30, 2023
7e1dcbb
ECOMMONS-1502: change footer link to 'site statistics' and update foo…
mhk33 Jun 1, 2023
637a74e
Fix Kaltura
BrandonKowalski Jun 1, 2023
af715fe
Merge upstream
BrandonKowalski Jun 5, 2023
abaef7a
Merge branch 'DSpace:main' into main
BrandonKowalski Jul 17, 2023
b9c2005
Disable end user agreement and set longer timeout. Fix for missing UI…
BrandonKowalski Jul 19, 2023
18143cb
Remove non-authors from author line on item list
BrandonKowalski Jul 20, 2023
d1e91f3
Degree discipline
BrandonKowalski Jul 20, 2023
0c6bb7e
Remove citation from simple view
BrandonKowalski Jul 20, 2023
bc6c92e
Remove licenses display
BrandonKowalski Jul 24, 2023
f28bfae
ECOMMONS-1534: add dspace fix for ILR theme header duplication prior …
mhk33 Jul 26, 2023
3bcd992
Custom submission process from homepage
BrandonKowalski Aug 1, 2023
5a2ba47
Merge remote-tracking branch 'origin/main'
BrandonKowalski Aug 1, 2023
c122b17
Fix for custom submission modal
BrandonKowalski Aug 2, 2023
c5c34b1
Fix for browse by labels
BrandonKowalski Aug 2, 2023
6fcc848
Feedback form fix
BrandonKowalski Aug 2, 2023
f0db000
Move permanent links location and fix links under rights and related DOI
BrandonKowalski Aug 2, 2023
24181af
Fix for submission info modal
BrandonKowalski Aug 3, 2023
65a50a6
Embargo thumbnail when dc.description.embargo populated
BrandonKowalski Aug 3, 2023
917e320
Disable privacy statement
BrandonKowalski Aug 3, 2023
32fb481
Keywords seperated by semicolon
BrandonKowalski Aug 3, 2023
5b308b3
Hide alternative author fields if author is present in simple view
BrandonKowalski Aug 3, 2023
5e607d9
Second intervention for submission
BrandonKowalski Aug 3, 2023
712f830
Fix order of search result metadata (authors, publisher, date)
BrandonKowalski Aug 3, 2023
fe8c631
I think this added the CC language
BrandonKowalski Aug 3, 2023
122f4d8
CC lanaguage attempt #2
BrandonKowalski Aug 4, 2023
321fbbb
Reduce banner size
BrandonKowalski Aug 23, 2023
853a49c
Add additional help page link
BrandonKowalski Aug 23, 2023
e2c4f2b
ECOMMONS-1563: add navbar to ilr theme
mhk33 Aug 24, 2023
0aa61fc
Fix issue with item view embargo image
BrandonKowalski Aug 25, 2023
4cb6dfc
Potentially fix the stupid date picker
BrandonKowalski Aug 25, 2023
4e3e9be
Make modal wider
BrandonKowalski Aug 26, 2023
79fb7aa
bug fix for hamburger menu not working in mobile (firefox/safari)
bmckinney Aug 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@
"inject": false,
"bundleName": "custom-theme"
},
{
"input": "src/themes/ecommons/styles/theme.scss",
"inject": false,
"bundleName": "ecommons-theme"
},
{
"input": "src/themes/ecommons/styles/theme.scss",
"inject": false,
"bundleName": "ilr-theme"
},
{
"input": "src/themes/dspace/styles/theme.scss",
"inject": false,
Expand Down
37 changes: 36 additions & 1 deletion config/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,40 @@
ui:
ssl: false
host: 0.0.0.0
port: 4000
nameSpace: /

rest:
ssl: true
host: api7.dspace.org
host: dspace7-dev.library.cornell.edu
port: 443
nameSpace: /server

auth:
ui:
timeUntilIdle: 14400000
idleGracePeriod: 14400000

info:
enableEndUserAgreement: false
enablePrivacyStatement: false

themes:
- name: ilr
extends: ecommons
uuid: '248b4901-f047-44d0-99b8-08613890ba79'
- name: ecommons
headTags:
- tagName: link
attributes:
rel: icon
href: assets/ecommons/images/favicons/favicon.ico
sizes: any
- tagName: link
attributes:
rel: apple-touch-icon
href: assets/ecommons/images/favicons/apple-touch-icon-152x152.png
- tagName: link
attributes:
rel: manifest
href: assets/ecommons/images/favicons/manifest.webmanifest
2 changes: 2 additions & 0 deletions src/app/app.component.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<ds-themed-root
[shouldShowFullscreenLoader]="(isAuthBlocking$ | async) || (isThemeLoading$ | async)"
[shouldShowRouteLoader]="isRouteLoading$ | async"></ds-themed-root>

<ds-submission-modal></ds-submission-modal>
14 changes: 9 additions & 5 deletions src/app/info/feedback/feedback-form/feedback-form.component.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<div class="row row-offcanvas row-offcanvas-right">
<div class="col-xs-12 col-sm-12 col-md-9 main-content">
<form class="primary" [formGroup]="feedbackForm" (ngSubmit)="createFeedback()">
<h2>{{ 'info.feedback.head' | translate }}</h2>
<p>{{ 'info.feedback.info' | translate }}</p>
<h2>Contact Us</h2>
<p><b>Do you wish to create an account?</b></p>
<p>By <a href="/login">logging in through Shibboleth</a>, you will automatically be registered for an eCommons account.</p>

<p>For any other questions or problems, please use this form and include your name in the comments. If you are writing to request approval to submit to a collection, please also include the URL of the desired collection in your request. If writing about a specific item, please include the handle in your message.</p>
<fieldset class="col p-0">
<div class="row">
<div class="control-group col-sm-12">
Expand All @@ -21,6 +24,7 @@ <h2>{{ 'info.feedback.head' | translate }}</h2>
<div class="control-group col-sm-12">
<label class="control-label" for="comments">{{ 'info.feedback.comments' | translate }}:&nbsp;</label>
<textarea id="comments" formControlName="message" class="form-control" name="message" cols="20" rows="5"> </textarea>
<p class="alert alert-info mt-2">Please remember to include your name in the comments.</p>
</div>
</div>
<ng-container *ngIf="feedbackForm.controls.message.invalid && (feedbackForm.controls.message.dirty || feedbackForm.controls.message.touched)"
Expand All @@ -29,14 +33,14 @@ <h2>{{ 'info.feedback.head' | translate }}</h2>
</ng-container>
<div class="row">
<div class="control-group col-sm-12">
<label class="control-label" for="page">{{ 'info.feedback.page-label' | translate }}&nbsp;</label>
<label class="control-label" for="page">{{ 'info.feedback.page-label' | translate }}:&nbsp;</label>
<input id="page" readonly class="form-control" name="page" type="text" value="" formControlName="page" autofocus="autofocus" title="{{ 'info.feedback.page_help' | translate }}">
<small class="text-muted">{{ 'info.feedback.page_help' | translate }}</small>
<small class="text-muted">This is the page where the contact link was clicked.</small>
</div>
</div>
<div class="row py-2">
<div class="control-group col-sm-12 text-right">
<button [disabled]="!feedbackForm.valid" class="btn btn-primary" name="submit" type="submit">{{ 'info.feedback.send' | translate }}</button>
<button [disabled]="!feedbackForm.valid" class="btn btn-primary" name="submit" type="submit">Send Message</button>
</div>
</div>
</fieldset>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,45 +42,4 @@ <h5 class="simple-view-element-header">{{"item.page.filesection.original.bundle"
</ds-pagination>
</div>
</div>
<div *ngVar="(licenses$ | async)?.payload as licenses">
<div *ngIf="hasValuesInBundle(licenses)">
<h5 class="simple-view-element-header">{{"item.page.filesection.license.bundle" | translate}}</h5>
<ds-pagination *ngIf="licenses?.page?.length > 0"
[hideGear]="true"
[hidePagerWhenSinglePage]="true"
[paginationOptions]="licenseOptions"
[pageInfoState]="licenses"
[collectionSize]="licenses?.totalElements"
[retainScrollPosition]="true">


<div class="file-section row" *ngFor="let file of licenses?.page;">
<div class="col-3">
<ds-themed-thumbnail [thumbnail]="(file.thumbnail | async)?.payload"></ds-themed-thumbnail>
</div>
<div class="col-7">
<dl class="row">
<dt class="col-md-4">{{"item.page.filesection.name" | translate}}</dt>
<dd class="col-md-8">{{ dsoNameService.getName(file) }}</dd>

<dt class="col-md-4">{{"item.page.filesection.size" | translate}}</dt>
<dd class="col-md-8">{{(file.sizeBytes) | dsFileSize }}</dd>

<dt class="col-md-4">{{"item.page.filesection.format" | translate}}</dt>
<dd class="col-md-8">{{(file.format | async)?.payload?.description}}</dd>


<dt class="col-md-4">{{"item.page.filesection.description" | translate}}</dt>
<dd class="col-md-8">{{file.firstMetadataValue("dc.description")}}</dd>
</dl>
</div>
<div class="col-2">
<ds-themed-file-download-link [bitstream]="file" [item]="item">
{{"item.page.filesection.download" | translate}}
</ds-themed-file-download-link>
</div>
</div>
</ds-pagination>
</div>
</div>
</ds-metadata-field-wrapper>
4 changes: 4 additions & 0 deletions src/app/item-page/item-page.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ import { ThemedItemAlertsComponent } from './alerts/themed-item-alerts.component
import {
ThemedFullFileSectionComponent
} from './full/field-components/file-section/themed-full-file-section.component';
import {
ItemPageKalturaFieldComponent
} from "./simple/field-components/specific-field/kaltura/item-page-kaltura-field.component";

const ENTRY_COMPONENTS = [
// put only entry components that use custom decorator
Expand Down Expand Up @@ -103,6 +106,7 @@ const DECLARATIONS = [
ItemAlertsComponent,
ThemedItemAlertsComponent,
BitstreamRequestACopyPageComponent,
ItemPageKalturaFieldComponent
];

@NgModule({
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<div class="item-page-kaltura-field">
<div *ngIf="item.metadata['dc.description.audio']?.length > 0">
<div *ngFor="let audio of item.metadata['dc.description.audio']; index as i;">
<iframe
type="text/javascript"
[src]=safeUrl(audio.value)
style="width: 640px;height: 400px"
allowfullscreen
webkitallowfullscreen
mozAllowFullScreen
>
</iframe>
</div>
</div>

<div *ngIf="item.metadata['dc.description.viewer']?.length > 0">
<div *ngFor="let viewer of item.metadata['dc.description.viewer']; index as i;">
<iframe
type="text/javascript"
[src]=safeUrl(viewer.value)
style="width: 640px;height: 400px"
allowfullscreen
webkitallowfullscreen
mozAllowFullScreen
>
</iframe>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import {TranslateLoader, TranslateModule} from '@ngx-translate/core';
import {ChangeDetectionStrategy, NO_ERRORS_SCHEMA} from '@angular/core';
import {ComponentFixture, TestBed, waitForAsync} from '@angular/core/testing';
import {TranslateLoaderMock} from '../../../../../shared/testing/translate-loader.mock';
import {MetadataValuesComponent} from '../../../../field-components/metadata-values/metadata-values.component';
import {ItemPageKalturaFieldComponent} from './item-page-kaltura-field.component';

let fixture: ComponentFixture<ItemPageKalturaFieldComponent>;

const mockValue = 'test value';

describe('ItemPageKalturaFieldComponent', () => {
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [TranslateModule.forRoot({
loader: {
provide: TranslateLoader,
useClass: TranslateLoaderMock
}
})],
declarations: [ItemPageKalturaFieldComponent, MetadataValuesComponent],
schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(ItemPageKalturaFieldComponent, {
set: {changeDetection: ChangeDetectionStrategy.Default}
}).compileComponents();
}));

it('should display display the correct metadata value', () => {
expect(fixture.nativeElement.innerHTML).toContain(mockValue);
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import {Component, Input} from '@angular/core';

import {Item} from '../../../../../core/shared/item.model';
import {DSONameService} from '../../../../../core/breadcrumbs/dso-name.service';

import {DomSanitizer} from '@angular/platform-browser';

@Component({
selector: 'ds-item-page-kaltura-field',
templateUrl: './item-page-kaltura-field.component.html'
})
/**
* This component is used for displaying the title (defined by the {@link DSONameService}) of an item
*/
export class ItemPageKalturaFieldComponent {

/**
* The item to display metadata for
*/
@Input() item: Item;

constructor(
public dsoNameService: DSONameService,
public sanitizer: DomSanitizer
) {

}

safeUrl(id: string) {
let untrusted = 'https://cdnapisec.kaltura.com/p/518251/embedPlaykitJs/uiconf_id/52424842?iframeembed=true&entry_id=' + id;
let trusted = this.sanitizer.bypassSecurityTrustResourceUrl(untrusted);
return trusted;
}

}
Loading