-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to decode reject reason in contract client #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
force-pushed
the
add-functions-to-decode-reject-reason
branch
from
July 8, 2024 10:37
e60eb7a
to
5044321
Compare
DOBEN
force-pushed
the
add-functions-to-decode-reject-reason
branch
from
July 8, 2024 12:05
ac14d56
to
e5ea591
Compare
limemloh
reviewed
Jul 8, 2024
soerenbf
reviewed
Jul 9, 2024
soerenbf
reviewed
Jul 10, 2024
DOBEN
force-pushed
the
add-functions-to-decode-reject-reason
branch
3 times, most recently
from
July 11, 2024 13:40
f2614f1
to
2d808e6
Compare
DOBEN
force-pushed
the
add-functions-to-decode-reject-reason
branch
from
July 11, 2024 13:56
2d808e6
to
82b7644
Compare
soerenbf
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice write-up of the error decoding rationale 😄
I still have one suggestion originating from @limemloh as seen below:
Otherwise I think it looks good 👍
soerenbf
reviewed
Jul 12, 2024
limemloh
reviewed
Jul 12, 2024
limemloh
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add methods to the
ContractClient
to decode the reject reason for a failed transaction during dry-run.Related Concordium/concordium-dapp-examples#87
Changes
ContractClient
to optionally keep track of the associated schema of the contract.create
method to theContractClient
to look up the embedded schema from the chain.new_with_schema
method to theContractClient
to create aContractClient
with a given schema.dry_run_update_with_reject_reason_info
anddry_run_update_raw_with_reject_reason_info
methods to theContractClient
. They are like thedry_run_update
anddry_run_update_raw
methods but in case of a reject, decode the reject reason into a human-readable error.decode_concordium_std_error
anddecode_smart_contract_revert
functions to facilitate reject reason decoding of failed transactions.