-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode reject reason at backend #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
force-pushed
the
decode-reject-reason
branch
from
July 5, 2024 13:46
28a7cd4
to
fabeac5
Compare
DOBEN
force-pushed
the
decode-reject-reason
branch
from
July 5, 2024 13:53
fabeac5
to
09278fa
Compare
soerenbf
reviewed
Jul 10, 2024
soerenbf
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, looks good to me 😄
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some backends send transactions on-chain. Until now, failed transactions only had an error code (such as
-1
,-2
, ...) associated with them. Since most transactions are triggered by input from users (which can be faulty), decoding thereject reason/error code
into human-understandable errors is preferred.The
contract_client
in the Rust SDK did not expose thereturnValue
of the failed transaction which is needed to decode error codes reliably. This PR updates the backends to use a new local Rust SDK with the required exposed functionality. Since the local Rust SDK is used now, thecontext
in some of the Docker build pipelines had to be updated.Related to Concordium/concordium-rust-sdk#199
This PR updates the
sponsored_transaction_service
in the track-and-trace dapp to use the new functionality from the Rust SDK. Other backends will be updated in follow-up PRs.Changes
context
of the Docker build pipelines which depend now on the local Rust SDK.sponsored_transaction_service
backend in the track-and-trace dapp.