Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode reject reason at backend #87

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Decode reject reason at backend #87

merged 10 commits into from
Jul 15, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Jul 2, 2024

Purpose

Some backends send transactions on-chain. Until now, failed transactions only had an error code (such as -1, -2, ...) associated with them. Since most transactions are triggered by input from users (which can be faulty), decoding the reject reason/error code into human-understandable errors is preferred.

The contract_client in the Rust SDK did not expose the returnValue of the failed transaction which is needed to decode error codes reliably. This PR updates the backends to use a new local Rust SDK with the required exposed functionality. Since the local Rust SDK is used now, the context in some of the Docker build pipelines had to be updated.

Related to Concordium/concordium-rust-sdk#199

This PR updates the sponsored_transaction_service in the track-and-trace dapp to use the new functionality from the Rust SDK. Other backends will be updated in follow-up PRs.

Changes

  • Update the submodule link to the Rust SDK.
  • Use local Rust SDK instead of some released/hardcoded Rust SDK versions.
  • Update the context of the Docker build pipelines which depend now on the local Rust SDK.
  • Decode the reject reason for a failed transaction during the dry-run at the sponsored_transaction_service backend in the track-and-trace dapp.

@DOBEN DOBEN requested review from soerenbf and limemloh July 9, 2024 18:14
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me 😄

@DOBEN DOBEN merged commit bc58adb into main Jul 15, 2024
57 checks passed
@DOBEN DOBEN deleted the decode-reject-reason branch July 15, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants