Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check of redirectUri #469

Merged
merged 2 commits into from
May 28, 2024
Merged

Remove check of redirectUri #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce93f9c
Throw an error if response is redirecting to redirectUri
limemloh May 27, 2024
6aca995
Remove check on redirect url when launching identity issuance
limemloh May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/browser-wallet/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Remove check for redirectUri when launching identity issuance. This check was causing issues with an upcoming identity provider and seems to provide no value.

## 1.5.1

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-wallet/src/background/identity-issuance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ async function startIdentityIssuance({
status: BackgroundResponseStatus.Error,
reason: `Initial location did not redirect as expected.`,
});
} else if (!response.url.includes(redirectUri)) {
} else {
launchExternalIssuance(response.url);
}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down
Loading