Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When launching identity issuance, the browser wallet will send a request the ID provider and be redirected to the onboarding flow.
The browser wallet checks the redirected URL does not contain the
redirectUrl
which is later used for signalling the end of the flow, but there is no error handling for this case, so the wallet fails silently and is stuck on the page for generating the request.One fix could be to produce an actual error, but this check seems arbitrary and provide no value, so instead I have removed it.
Also, it was hit by accident by an upcoming identity provider.
I have checked that this still works with every identity provider on testnet.
Changes
Checklist
hard-to-understand areas.