Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check of redirectUri #469

Merged
merged 2 commits into from
May 28, 2024
Merged

Remove check of redirectUri #469

merged 2 commits into from
May 28, 2024

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented May 27, 2024

Purpose

When launching identity issuance, the browser wallet will send a request the ID provider and be redirected to the onboarding flow.
The browser wallet checks the redirected URL does not contain the redirectUrl which is later used for signalling the end of the flow, but there is no error handling for this case, so the wallet fails silently and is stuck on the page for generating the request.

One fix could be to produce an actual error, but this check seems arbitrary and provide no value, so instead I have removed it.
Also, it was hit by accident by an upcoming identity provider.
I have checked that this still works with every identity provider on testnet.

Changes

  • Remove the check of the redirected identity issuance url.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why this extra measure was in place, but everything works as expected for me as well when I test this.

@limemloh limemloh merged commit e7224ec into main May 28, 2024
7 checks passed
@limemloh limemloh deleted the check-redirect branch May 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants