-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add particle sparser manipulator #4916
Merged
psychocoderHPC
merged 1 commit into
ComputationalRadiationPhysics:dev
from
BrianMarre:topic-addSparser
Jun 10, 2024
Merged
add particle sparser manipulator #4916
psychocoderHPC
merged 1 commit into
ComputationalRadiationPhysics:dev
from
BrianMarre:topic-addSparser
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMarre
force-pushed
the
topic-addSparser
branch
from
May 31, 2024 10:49
a21cd05
to
eee4c20
Compare
ikbuibui
added
changelog
PR's marked with this label will be added to the changelog
component: core
in PIConGPU (core application)
labels
May 31, 2024
chillenzer
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing worth blocking a merge.
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.def
Outdated
Show resolved
Hide resolved
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.def
Show resolved
Hide resolved
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.hpp
Outdated
Show resolved
Hide resolved
BrianMarre
force-pushed
the
topic-addSparser
branch
2 times, most recently
from
May 31, 2024 13:14
c78baec
to
6db0b8f
Compare
PrometheusPi
previously approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay - just two (one essential) question
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.hpp
Show resolved
Hide resolved
BrianMarre
force-pushed
the
topic-addSparser
branch
from
June 4, 2024 15:11
6db0b8f
to
87e0e21
Compare
psychocoderHPC
requested changes
Jun 5, 2024
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/manipulators/unary/SparserMacroParticlesPerSuperCell.hpp
Outdated
Show resolved
Hide resolved
BrianMarre
force-pushed
the
topic-addSparser
branch
from
June 7, 2024 07:17
87e0e21
to
4991b72
Compare
psychocoderHPC
approved these changes
Jun 10, 2024
psychocoderHPC
merged commit Jun 10, 2024
585dd1b
into
ComputationalRadiationPhysics:dev
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog
PR's marked with this label will be added to the changelog
component: core
in PIConGPU (core application)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a particle sparser that deletes all particles not in one cell of each superCell