Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 22: migrate to httr2 #83

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Issue 22: migrate to httr2 #83

merged 6 commits into from
Sep 21, 2024

Conversation

AliSajid
Copy link
Collaborator

@AliSajid AliSajid commented Sep 21, 2024

Pull Request

Description

This PR completely removes the dependency on httr, migrating to httr2 transparently.
There are no major code changes or differences for the end-user.

Changes

  • build: add httr2 as a dependency
  • feat: add .ilincsBaseUrl to parametrize the base URL
  • build: update the dependencies in renv
  • feat: update the getSignature() method to use httr2
  • feat: migrate getConcordants to httr2
  • feat: remove references to httr

Related Issues

Closes #22

Also closes #77, #78 and #79

Checklist

  • I have tested these changes locally
  • I have updated relevant documentation
  • I have added/updated tests if applicable
  • All tests pass successfully
  • I have reviewed my code changes
  • I have addressed any feedback from code reviews

@AliSajid AliSajid linked an issue Sep 21, 2024 that may be closed by this pull request
@AliSajid AliSajid merged commit 038dea5 into devel Sep 21, 2024
4 checks passed
@AliSajid AliSajid deleted the 22-migrate-to-httr2 branch September 21, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation with more details Migrate to httr2
1 participant