Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to httr2 #22

Closed
AliSajid opened this issue Sep 14, 2023 · 4 comments · Fixed by #83
Closed

Migrate to httr2 #22

AliSajid opened this issue Sep 14, 2023 · 4 comments · Fixed by #83
Labels
enhancement New feature or request
Milestone
Bioconductor-Resu...

Comments

@AliSajid
Copy link
Collaborator

Related Issues:

  1. ropensci/webmockr#122
  2. ropensci/vcr#237

Since httr has been deprecated, it would be a good idea to migrate to httr2 for compliance.

A blocker right now is that we rely on vcr and webmockr for some of our tests. Once the above issues are resolved we should move to httr2.
@sckott
Copy link

sckott commented Sep 23, 2023

Sorry about the hold up on httr2 integration - I can't promise a date when it will be done, but I'm hoping to get back to it soon

@sckott
Copy link

sckott commented Jul 25, 2024

Both vcr and webmockr now support httr2 with the latest versions of each pkg on cran. Let me know if you run into any issues

@AliSajid
Copy link
Collaborator Author

@sckott Woohoo! Thank you for all the work! I'll be running tests on this soon. This made my day. :)

@sckott
Copy link

sckott commented Jul 25, 2024

great!

@AliSajid AliSajid added the enhancement New feature or request label Aug 16, 2024
@AliSajid AliSajid added this to the Bioconductor-Resubmission milestone Aug 16, 2024
@AliSajid AliSajid linked a pull request Sep 21, 2024 that will close this issue
Issue 22: migrate to httr2 #83
Merged
6 tasks
@AliSajid AliSajid mentioned this issue Sep 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Bioconductor-Resubmission
Development

Successfully merging a pull request may close this issue.

Issue 22: migrate to httr2 CogDisResLab/drugfindR
2 participants
@AliSajid @sckott