Use non-blocking action logic for first point #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should not be affected by merging #60, (if skip_path == true we need to do the approach as normal and then it should work fine). please confirm if you have the time |
The current sync/blocking action can quite often trigger battery undervoltage as low voltage condition will not abort until the first path is reached. Also skip_area/skip_path does not apply until the first point is reached.
olliewalsh
force-pushed
the
first_point_non_blocking
branch
from
c820d43
to
56b0a7a
Compare
Rebased/updated. Better for skip_path to apply to the first point too, otherwise like skip_area it can be very tedious to skip through multiple paths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current sync/blocking action can quite often trigger battery undervoltage as low voltage condition will not abort until the first path is reached.
Also skip_area does not apply until the first point is reached.