Switch to #[classmethod] for SpendBundle::py_aggregate

crates/chia-bls/src/gtelement.rs

@@ -6,6 +6,8 @@ use clvmr::sha2::Sha256;
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 use std::fmt;
 use std::hash::{Hash, Hasher};
 use std::io::Cursor;
@@ -118,11 +120,8 @@ impl GTElement {
 
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(_cls: &Bound<'_, PyType>, instance: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // ignore child case
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _instance: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 
     #[must_use]

crates/chia-bls/src/public_key.rs

@@ -8,6 +8,8 @@ use clvmr::sha2::Sha256;
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 use std::fmt;
 use std::hash::{Hash, Hasher};
 use std::io::Cursor;
@@ -327,11 +329,8 @@ impl PublicKey {
 
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(_cls: &Bound<'_, PyType>, instance: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // ignore child case
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _instance: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 
     #[pyo3(name = "get_fingerprint")]

crates/chia-bls/src/secret_key.rs

@@ -7,6 +7,8 @@ use hkdf::HkdfExtract;
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 use std::fmt;
 use std::hash::{Hash, Hasher};
 use std::io::Cursor;
@@ -272,11 +274,8 @@ impl SecretKey {
 
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(_cls: &Bound<'_, PyType>, instance: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // ignore child case
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _instance: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 
     #[pyo3(name = "derive_hardened")]

crates/chia-bls/src/signature.rs

@@ -6,6 +6,8 @@ use clvmr::sha2::Sha256;
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 use std::borrow::Borrow;
 use std::fmt;
 use std::hash::{Hash, Hasher};
@@ -494,10 +496,10 @@ impl Signature {
     #[pyo3(name = "from_parent")]
     pub fn from_parent(
         _cls: &Bound<'_, PyType>,
-        py: Python<'_>,
-        instance: Self,
+        _py: Python<'_>,
+        _instance: Self,
     ) -> PyResult<PyObject> {
-        Ok(instance.into_py(py))
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 
     #[pyo3(name = "pair")]

crates/chia-consensus/src/gen/owned_conditions.rs

@@ -12,6 +12,8 @@ use chia_py_streamable_macro::{PyJsonDict, PyStreamable};
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 
 #[derive(Streamable, Hash, Debug, Clone, Eq, PartialEq)]
 #[cfg_attr(
@@ -155,11 +157,8 @@ fn convert_agg_sigs(a: &Allocator, agg_sigs: &[(PublicKey, NodePtr)]) -> Vec<(Pu
 impl OwnedSpendConditions {
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(_cls: &Bound<'_, PyType>, instance: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // ignore child case - though this could be extended in the future to support child class
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _instance: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 }
 
@@ -168,10 +167,8 @@ impl OwnedSpendConditions {
 impl OwnedSpendBundleConditions {
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(_cls: &Bound<'_, PyType>, instance: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // ignore child case - though this could be extended in the future to support child class
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _instance: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 }
+

crates/chia-protocol/src/coin.rs

@@ -10,6 +10,8 @@ use clvmr::sha2::Sha256;
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 
 #[streamable]
 #[derive(Copy)]
@@ -62,13 +64,8 @@ impl Coin {
 impl Coin {
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(cls: &Bound<'_, PyType>, coin: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // Convert result into potential child class
-            let instance = cls.call1((coin.parent_coin_info, coin.puzzle_hash, coin.amount))?;
-
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _coin: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 }
 

crates/chia-protocol/src/program.rs

@@ -492,11 +492,8 @@ impl ToJsonDict for Program {
 impl Program {
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(_cls: &Bound<'_, PyType>, instance: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // ignore child case
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _instance: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 }
 

crates/chia-protocol/src/spend_bundle.rs

@@ -16,6 +16,8 @@ use clvmr::ENABLE_FIXED_DIV;
 use pyo3::prelude::*;
 #[cfg(feature = "py-bindings")]
 use pyo3::types::PyType;
+#[cfg(feature = "py-bindings")]
+use pyo3::exceptions::PyNotImplementedError;
 
 #[streamable(subclass)]
 pub struct SpendBundle {
@@ -113,16 +115,8 @@ impl SpendBundle {
 
     #[classmethod]
     #[pyo3(name = "from_parent")]
-    pub fn from_parent(cls: &Bound<'_, PyType>, spend_bundle: Self) -> PyResult<PyObject> {
-        Python::with_gil(|py| {
-            // Convert result into potential child class
-            let instance = cls.call(
-                (spend_bundle.coin_spends, spend_bundle.aggregated_signature),
-                None,
-            )?;
-
-            Ok(instance.into_py(py))
-        })
+    pub fn from_parent(_cls: &Bound<'_, PyType>, _spend_bundle: Self) -> PyResult<PyObject> {
+        Err(PyNotImplementedError::new_err("This class does not support from_parent()."))
     }
 
     #[pyo3(name = "name")]