-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to #[classmethod] for SpendBundle::py_aggregate #678
Conversation
Pull Request Test Coverage Report for Build 10882840971Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Did you change the line endings in these files? The diff seems way too large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought you'd need to use the passed-in cls
type eomshow
we should try going back to invoking the derived class with all the fields of the class itself, as if it is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a few simplification opportunities in the error propagation, and I think the type stubs can be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. I thought you used to have a python test as well, to ensure it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good, you just missed one place that sill uses with_gil()
Co-authored-by: Arvid Norberg <[email protected]>
This will allow derived classes to return themselves rather than the SpendBundle parent class