Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-1716 Speedup get_header_blocks_in_range w.r.t. blocks with no transactions #18829

Merged
merged 1 commit into from
Nov 6, 2024
Merged

CHIA-1716 Speedup get_header_blocks_in_range w.r.t. blocks with no transactions #18829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions chia/consensus/blockchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,10 @@ async def get_header_blocks_in_range(
raise ValueError(f"Block at {block.header_hash} is no longer in the blockchain (it's in a fork)")
if tx_filter is False:
header = get_block_header(block, [], [])
elif block.transactions_generator is None:
# There is no point in getting additions and removals for
# blocks that do not have transactions.
header = get_block_header(block, [], [])
else:
tx_additions: list[CoinRecord] = [
c for c in (await self.coin_store.get_coins_added_at_height(block.height)) if not c.coinbase
Expand Down
Loading