Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1716 Speedup get_header_blocks_in_range w.r.t. blocks with no transactions #18829

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

There is no point in getting additions and removals for blocks that do not have transactions.

Current Behavior:

get_header_blocks_in_range prepares additions and removals even blocks without transactions.

New Behavior:

get_header_blocks_in_range only prepares additions and removals for blocks with transactions.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Nov 5, 2024
@AmineKhaldi AmineKhaldi self-assigned this Nov 5, 2024
Copy link

Pull Request Test Coverage Report for Build 11692794344

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.927%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/server/node_discovery.py 1 80.73%
chia/full_node/full_node.py 1 86.04%
chia/daemon/client.py 1 74.1%
chia/data_layer/data_layer.py 2 86.09%
chia/farmer/farmer_api.py 2 94.36%
chia/_tests/core/daemon/test_daemon.py 3 99.59%
chia/daemon/server.py 7 83.28%
Totals Coverage Status
Change from base Build 11691476343: 0.02%
Covered Lines: 102818
Relevant Lines: 112848

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review November 6, 2024 10:25
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner November 6, 2024 10:25
@arvidn
Copy link
Contributor

arvidn commented Nov 6, 2024

are the reward coins for non-transaction blocks added with the next transaction block?

@AmineKhaldi
Copy link
Contributor Author

are the reward coins for non-transaction blocks added with the next transaction block?

IIRC they get added in the transaction block after the next transaction block.

@pmaslana pmaslana merged commit 816462d into Chia-Network:main Nov 6, 2024
358 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants