Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-1673] Comment out a manual ._finish_sync() call #18783

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[CHIA-1673] Comment out a manual ._finish_sync() call #18783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daf2c9f
Delete a manual `._finish_sync()` call
Quexington Oct 28, 2024
1ec5e1f
Add comment
Quexington Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion chia/simulator/add_blocks_in_batches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,8 @@ async def add_blocks_in_batches(
peak_fb, state_change_summary, None
)
await full_node.peak_post_processing_2(peak_fb, None, state_change_summary, ppp_result)
await full_node._finish_sync()
# this is commented out because we already call post_processing_peak2 which already sends
# the peak to the wallet this causes finish_sync to resend a peak the wallet already received
# that will cause the wallet to reorg the peak (even though its redundant) which causes it to
# go out of sync momentarily. When this redundant behavior is fixed, this line can be uncommented.
# await full_node._finish_sync()
Loading