[CHIA-1673] Comment out a manual ._finish_sync() call
#18783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Fixed
Quexington
changed the title
._finish_sync() call._finish_sync() call
Quexington
changed the title
._finish_sync() call._finish_sync() call
Quexington
changed the title
._finish_sync() call._finish_sync() call
almogdepaz
approved these changes
Oct 30, 2024
emlowe
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some wallet tests were turning flaky around this call being in. @almogdepaz says it's due to a revealed bug in the wallet sync process that he intends to fix. For now, we'll comment this out to help test flakiness.