Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide to-address in wallet transaction history #2446

Merged
merged 1 commit into from
Sep 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions packages/wallets/src/components/WalletHistory.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
import {
AddressBookContext,
Card,
CopyToClipboard,
Flex,
StateColor,
TableControlled,
Expand Down Expand Up @@ -153,6 +152,24 @@ const getCols = (type: WalletType, isSyncing, getOfferRecord, navigate, location
});
}

const addressEl = shouldObscureAddress ? (
<Tooltip
title={
<StyledWarning>
<Trans>This is not a valid address for sending funds to</Trans>
</StyledWarning>
}
>
<span>
{displayEmoji} {displayAddress}
</span>
</Tooltip>
) : (
<span>
{displayEmoji} {displayAddress}
</span>
);

return (
<Flex
flexDirection="column"
Expand All @@ -167,25 +184,7 @@ const getCols = (type: WalletType, isSyncing, getOfferRecord, navigate, location
<Typography variant="caption" component="span">
<Trans>To: </Trans>
</Typography>
<Tooltip
title={
<Flex flexDirection="column" gap={1}>
{shouldObscureAddress && (
<StyledWarning>
<Trans>This is not a valid address for sending funds to</Trans>
</StyledWarning>
)}
<Flex flexDirection="row" alignItems="center" gap={1}>
<Box maxWidth={200}>{row.toAddress}</Box>
{!shouldObscureAddress && <CopyToClipboard value={row.toAddress} fontSize="small" />}
</Flex>
</Flex>
}
>
<span>
{displayEmoji} {displayAddress}
</span>
</Tooltip>
{addressEl}
</div>
<Flex gap={0.5}>
{isIncomingClawback && (
Expand Down
Loading