Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide to-address in wallet transaction history #2446

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

ChiaMineJP
Copy link
Contributor

image

image

@ChiaMineJP ChiaMineJP added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 14, 2024
@ChiaMineJP ChiaMineJP self-assigned this Aug 14, 2024
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner August 14, 2024 13:58
@markelrod
Copy link
Contributor

Hey Izumi - we're getting feedback that hiding the To-address is going to be seen as a bug. For now let's truncate the address for display and not allow user to copy the full address. Does that make sense?

@ChiaMineJP
Copy link
Contributor Author

@markelrod Updated the code to do so.

Remove.tooltip.from.wallet.history.mov

@ChiaMineJP ChiaMineJP closed this Sep 4, 2024
@ChiaMineJP ChiaMineJP reopened this Sep 4, 2024
@pmaslana pmaslana merged commit f74d166 into main Sep 4, 2024
12 of 15 checks passed
@pmaslana pmaslana deleted the cmj.hide-to-address branch September 4, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants