Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check python version for set_int_max_str_digits() #60

Closed
wants to merge 1 commit into from

Conversation

kywch
Copy link
Contributor

@kywch kywch commented May 29, 2023

nmmo is mainly based on python 3.9 and 3.10, and sys.set_int_max_str_digits() was introduced in 3.11

@herbiebradley herbiebradley changed the base branch from main to release/0.2.2 June 1, 2023 14:46
@herbiebradley
Copy link
Collaborator

nmmo is mainly based on python 3.9 and 3.10, and sys.set_int_max_str_digits() was introduced in 3.11

https://docs.python.org/3.9/library/sys.html#sys.set_int_max_str_digits This function appears to be in 3.9.14?

@kywch
Copy link
Contributor Author

kywch commented Jun 1, 2023

Oh, the function is also introduced in 3.10.7 -- https://docs.python.org/3.10/library/sys.html#sys.set_int_max_str_digits

I ran into this error when using ubuntu LTS based dockers, which have 3.10.6 (ubuntu 22.04.2 LTS) and 3.9.12 (20.04.5 LTS). It'd be great if a similar version check is in place. Thanks!

@herbiebradley
Copy link
Collaborator

Oh, the function is also introduced in 3.10.7 -- https://docs.python.org/3.10/library/sys.html#sys.set_int_max_str_digits

I ran into this error when using ubuntu LTS based dockers, which have 3.10.6 (ubuntu 22.04.2 LTS) and 3.9.12 (20.04.5 LTS). It'd be great if a similar version check is in place. Thanks!

Ah right, makes sense! Looks like we need to check >= 3.9.14 and >= 3.10.7 then.

@herbiebradley
Copy link
Collaborator

Closed by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants