[TS] Delete VertexRange, use isTranslucent, fix partition tree sorting on geometry with negative dot products #2655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VertexRange
as since the introduction of the translucency sorting system its firstoffset
field wasn't getting used anymore. It can simply be calculated on the fly as a prefix sum. Currently missing vertex ranges are replicated as-1
lengths which are distinct from a length of zero. I don't know if this is actually necessary or if we can just use a zero length as the default.isTranslucent
method on terrain render passes and materials instead of checking equalityfloatToComparableInt
to actually be correct, it doesn't seem to have been correct previously.