Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SteeringWheel.Heating #630

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add SteeringWheel.Heating #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ have been removed from the [VSS syntax](docs-gen/content/rule_set/data_entry/sen

## Planned Changes VSS 4.1

-

### Deprecated or Deleted signals

* `Vehicle.Cabin.Seat.*.*.Heating` deprecated from 4.1. New signal `Vehicle.Cabin.Seat.*.*.HeatingCooling` added.

## Planned Changes VSS 5.0

Expand Down
3 changes: 3 additions & 0 deletions spec/Cabin/SingleSeat.vspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,16 @@ SeatBeltHeight:
Position is relative within available movable range of the seat belt.
0 = Lowermost position supported.
Heating:
deprecation: v4.1 replaced with HeatingCooling
datatype: int8
type: actuator
min: -100
max: 100
unit: percent
description: Seat cooling / heating. 0 = off. -100 = max cold. +100 = max heat.

#include include/ItemHeatingCooling.vspec

Massage:
datatype: uint8
type: actuator
Expand Down
2 changes: 2 additions & 0 deletions spec/Chassis/Chassis.vspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ SteeringWheel.Extension:
unit: percent
description: Steering wheel column extension from dashboard. 0 = Closest to dashboard. 100 = Furthest from dashboard.

#include include/ItemHeatingCooling.vspec SteeringWheel

#
# Accelerator
#
Expand Down
14 changes: 14 additions & 0 deletions spec/include/ItemHeatingCooling.vspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#
# All files and artifacts in this repository are licensed under the
# provisions of the license provided by the LICENSE file in this repository.
#


HeatingCooling:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed TemperatureControl (in previous PR version) to HeatingCooling, I think that I prefer that over RelativeTemperature but we can discuss that at next meeting

datatype: int8
type: actuator
min: -100
max: 100
unit: percent
description: Heating or Cooling requsted for the Item.
-100 = Maximum cooling, 0 = Heating/cooling deactivated, 100 = Maximum heating.