Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SteeringWheel.Heating #630

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add SteeringWheel.Heating #630

merged 1 commit into from
Sep 13, 2023
+23 −1

Conversation

erikbosch
Copy link
Collaborator

@erikbosch
Copy link
Collaborator Author

erikbosch commented Jul 11, 2023 •
edited
Loading

Meeting notes:

  • Please review
  • Nick: Maybe call it something with both heat and cooling. ("TemperatureControl")
  • Pierre: Check if it can be aligned with seat heating/cooling (reusable signal)
  • Nick: Not all vehicle will support negative values
  • Erik: Traditional "VSS solution" has been to define an overlay where you specify min/max that your vehicle can handle.

@erikbosch
Copy link
Collaborator Author

AP: Erik to update PR

@erikbosch erikbosch marked this pull request as ready for review July 20, 2023 09:34
@SebastianSchildt
Copy link
Collaborator

Meeting 08/15

  • Is "TemperatureControl" a good name (it sounds like HVAC, but this signal is not very usable for that (relative scale))
  • Is "Control" is a good suffix
  • Maybe something something with "Relative" e.g. RelativeTemperature

@erikbosch erikbosch force-pushed the erik_steeringwheel branch 2 times, most recently from 39bf45b to 950ee25 Compare September 4, 2023 10:52
@erikbosch
Add SteeringWheel.HeatingCooling
5ac51bb 
Signed-off-by: Erik Jaegervall <[email protected]>
erikbosch
erikbosch commented Sep 4, 2023
View reviewed changes
spec/include/ItemHeatingCooling.vspec
#


HeatingCooling:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed TemperatureControl (in previous PR version) to HeatingCooling, I think that I prefer that over RelativeTemperature but we can discuss that at next meeting

@erikbosch
Copy link
Collaborator Author

Meeting notes:

  • Erik changed name to "HeatingCooling"
  • Daniel: Would not use term "temperature" if unit is not celsius, possibly better with "intensity"
  • Sebastian: Possibly "HeatingIntensity"
  • Erik: Please review/discuss until next week

@erikbosch
Copy link
Collaborator Author

Meeting notes: merge

@erikbosch erikbosch merged commit 3d47838 into COVESA:master Sep 13, 2023
3 checks passed
@erikbosch erikbosch deleted the erik_steeringwheel branch September 13, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbosch @SebastianSchildt