DE53956 WCAG 2.2 Update input style to match core #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostlyfabulous
commented
Jul 12, 2023
| border: 1px solid; | ||
| border-style: none; |
There was a problem hiding this comment.
Remove border from link styled as button to match core button component:
https://github.com/BrightspaceUI/core/blob/main/components/button/button-styles.js#L8
mostlyfabulous
commented
Jul 12, 2023
| @@ -152,7 +152,7 @@ $_documentContainer.innerHTML = `<dom-module id="d2l-labs-file-uploader"> | |||
| text-decoration: none; | |||
| } | |||
| .d2l-file-uploader-browse-label-focus { | |||
| box-shadow: 0 0 0 4px rgba(0, 111, 191, 0.3); | |||
There was a problem hiding this comment.
This adds the 2px white border and then a 4px celestine outer border when focused.
e.g.
Celestine:
tylergee
approved these changes
Jul 13, 2023
mostlyfabulous
deleted the
awong/20.23.8/DE53956-WCAG-2.2-update-input-style-to-match-core
branch
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DE53956: [WCAG2.2] Activity Feed > Several buttons with enclosed focus not meeting Focus appearance requirements
Fixes: