Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop zone should be outlined area instead of entire document #43

Open
zwilson2 opened this issue Jul 27, 2017 · 4 comments
Open

Drop zone should be outlined area instead of entire document #43

zwilson2 opened this issue Jul 27, 2017 · 4 comments

Comments

@zwilson2
Copy link

I would like the option to be able to make the outlined drop zone the only area the file can be dropped rather than the entire page.

@dbatiste
Copy link
Contributor

dbatiste commented Jul 27, 2017

I think the "file drop" capability could be factored into a behavior that can be attached to any HTML element. I think this would better enable what you are describing, and many other use cases.

@dlockhart dlockhart changed the title The drop zone is the document instead of the outlined area Drop zone should be outlined area instead of entire document Jul 27, 2017
@dlockhart
Copy link
Contributor

@nicolebezaire, do you know why this originally was built to have the entire window be the drop zone? Would switching it to just be the outlined area be a problem, or do we need to introduce an configurable option?

@ianmclean2011
Copy link
Contributor

@dlockhart I believe this was originally built to have the entire window be the drop zone because that's the functionality that we wanted for the import question dialog, and so it was built that way for our team's use of it. It would probably be a good idea though for there to be an option allowing the user to decide whether they want that or not.

@nicolebezaire
Copy link

@dlockhart -- I think this would make best sense as an option to support cases where there might be more than one uploader on the page. The concept of supporting a drop anywhere on the page is primarily about ease of use (why force the precision of hitting a drop target when dragging a file onscreen demonstrates a clear intention?) This is also becoming a bit of a pattern on the web where sites like imgur and Dropbox support a file drop anywhere on the page for upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants