Add attribute to only allow file drop in the drop zone. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
reviewed
Jul 27, 2017
| "single_file_upload_text": "Drag and drop a file anywhere on this screen or", | ||
| "single_file_upload_text_drop_zone": "Drag and drop a file anywhere in this area or", | ||
| "multiple_file_upload_text": "Drag and drop files anywhere on this screen or", | ||
| "multiple_file_upload_text_drop_zone": "Drag and drop files anywhere in this area or", |
There was a problem hiding this comment.
If we end up going with this solution, we'll need to send these off for translation. Another idea (if we want to do this) would be to use more generic text that covers both cases.
There was a problem hiding this comment.
Yup. I just wanted to make sure that all the changes needing to be made were in if this is something we do. This definitely should be looked over by a designer to properly word this.
|
Closing due to age. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43